Repository navigation
Fix ZIP entry size variable metadata - #8796
Merged
Merged
Conversation
bamaer
approved these changes
Oct 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #4484.
HOP_ZIP_MAX_ENTRY_SIZEwas registered without its default value, while the internalHOP_ZIP_MAX_ENTRY_SIZE_DEFAULT_STRINGhelper was incorrectly exposed as a separate configurable variable.This change registers the real variable with its
4294967295default and keeps the helper constant out of the variable registry.A regression test verifies the default value, description, and absence of the helper entry.
Validation:
./mvnw -pl core -Dtest=VariableRegistryTest test./mvnw -pl core test— 1,612 tests passed./mvnw spotless:check -pl coregit diff --checkI hereby declare this contribution to be licensed under the Apache License Version 2.0, January 2004