Skip to content

AI Assistant hardening #8757 - #8784

Open
bamaer wants to merge 4 commits into
apache:mainfrom
bamaer:8757
Open

bamaer wants to merge 4 commits into
apache:mainfrom
bamaer:8757

Conversation

@bamaer

@bamaer bamaer commented Oct 7, 2026

Copy link
Copy Markdown
Contributor

Please add a meaningful description for your change here

fixes #8757

Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

  • Run mvn clean install apache-rat:check to make sure basic checks pass. A more thorough check will be performed on your pull request automatically.
  • If you have a group of commits related to the same change, please squash your commits into one and force push your branch using git rebase -i.
  • Mention the appropriate issue in your description (for example: addresses #123), if applicable.

To make clear that you license your contribution under the Apache License Version 2.0, January 2004
you have to acknowledge this by using the following check-box.

bamaer added 3 commits October 7, 2026 13:43
Fix first:
- AI Provider keeps its type on save; files saved without one can be repaired
- Checked context (and the log of a new run) is sent on every turn
- Secrets masked by encoder prefix and field name suffix, URL credentials masked
- Sharing line shows what is actually sent
- Sessions matched on the pipeline/workflow, not its name
- Ctrl/Cmd+Shift shortcuts work from text fields

Context and prompts:
- Context size and max output tokens on AI Provider (Ollama num_ctx 16k default)
- Prompt size check before sending, compact plugin catalog, transform settings
- Tagged context, answer in the user's language, proposals only when asked
- Proposals repaired once (JSON-only), recovered from text, normalised before review
- Evaluation set against real models (skipped unless configured)

Proposals and data safety:
- Protected metadata types, overwrite confirmation and undo, all-or-nothing apply
- Deletes, replacements and overwrites opt-in; AGENTS.md no longer read by default
- Payload preview and All button in the metadata picker

Sessions:
- Scoped to the project, linkable to the open file, kept per project in the audit folder
- Prompt built on the UI thread, Stop frees the session, closed files released

Window and provider editor:
- One name (AI Assistant), i18n, empty states, Send feedback, review dialog states
- Float/Dock move the view and are remembered; question field grows with its text
- Prompt history with Up/Down, focus line, Sharing explanations
- Provider editor in tabs, model column from Refresh models, validation on save
…s, all-or-nothing apply, metadata allow list, close option, log choice per run, i18n, window tests
…he changed flag, hop reversal, alias scoping, undo metadata confirmation, structured answer retry, repair results
Comment thread plugins/tech/ai/src/main/java/org/apache/hop/ai/engine/AiAdvisorEngine.java Outdated
Comment thread plugins/tech/ai/src/main/java/org/apache/hop/ai/engine/AiNodeSettings.java Outdated
… changes until answered and across restarts, block hop loops of any length, keep options that are off, stop waiting questions when Hop GUI exits
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Task]: AI Assistant hardening

2 participants