Repository navigation
Issue #8777: Fix false positive result on error and populate schema in Action Truncate tables #8778
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
107 changes: 107 additions & 0 deletions
107
...rc/test/java/org/apache/hop/workflow/actions/truncatetables/ActionTruncateTablesTest.java
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,107 @@ | ||
| /* | ||
| * Licensed to the Apache Software Foundation (ASF) under one or more | ||
| * contributor license agreements. See the NOTICE file distributed with | ||
| * this work for additional information regarding copyright ownership. | ||
| * The ASF licenses this file to You under the Apache License, Version 2.0 | ||
| * (the "License"); you may not use this file except in compliance with | ||
| * the License. You may obtain a copy of the License at | ||
| * | ||
| * http://www.apache.org/licenses/LICENSE-2.0 | ||
| * | ||
| * Unless required by applicable law or agreed to in writing, software | ||
| * distributed under the License is distributed on an "AS IS" BASIS, | ||
| * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| * See the License for the specific language governing permissions and | ||
| * limitations under the License. | ||
| */ | ||
|
|
||
| package org.apache.hop.workflow.actions.truncatetables; | ||
|
|
||
| import static org.junit.jupiter.api.Assertions.assertEquals; | ||
| import static org.junit.jupiter.api.Assertions.assertFalse; | ||
| import static org.mockito.ArgumentMatchers.any; | ||
| import static org.mockito.ArgumentMatchers.anyString; | ||
| import static org.mockito.Mockito.mock; | ||
| import static org.mockito.Mockito.when; | ||
|
|
||
| import org.apache.hop.core.HopClientEnvironment; | ||
| import org.apache.hop.core.Result; | ||
| import org.apache.hop.core.logging.HopLogStore; | ||
| import org.apache.hop.core.logging.LogLevel; | ||
| import org.apache.hop.workflow.Workflow; | ||
| import org.apache.hop.workflow.WorkflowMeta; | ||
| import org.junit.jupiter.api.BeforeAll; | ||
| import org.junit.jupiter.api.Test; | ||
|
|
||
| class ActionTruncateTablesTest { | ||
|
|
||
| @BeforeAll | ||
| static void setUp() throws Exception { | ||
| HopClientEnvironment.init(); | ||
| HopLogStore.init(); | ||
| } | ||
|
|
||
| @Test | ||
| void testExecuteWithNoConnection() { | ||
| ActionTruncateTables action = new ActionTruncateTables(); | ||
| action.setConnection(null); | ||
|
|
||
| Result result = action.execute(new Result(), 0); | ||
|
|
||
| assertFalse(result.getResult()); | ||
| assertEquals(1, result.getNrErrors()); | ||
| } | ||
|
|
||
| @Test | ||
| void testExecuteWithNonExistentConnection() { | ||
| ActionTruncateTables action = new ActionTruncateTables(); | ||
| action.setConnection("non-existent-db"); | ||
|
|
||
| WorkflowMeta workflowMeta = mock(WorkflowMeta.class); | ||
| when(workflowMeta.findDatabase(anyString(), any())).thenReturn(null); | ||
|
|
||
| Workflow workflow = mock(Workflow.class); | ||
| when(workflow.getWorkflowMeta()).thenReturn(workflowMeta); | ||
| when(workflow.getLogLevel()).thenReturn(LogLevel.BASIC); | ||
|
|
||
| action.setParentWorkflow(workflow); | ||
| action.setParentWorkflowMeta(workflowMeta); | ||
|
|
||
| Result result = action.execute(new Result(), 0); | ||
|
|
||
| assertFalse(result.getResult()); | ||
| assertEquals(1, result.getNrErrors()); | ||
| } | ||
|
|
||
| @Test | ||
| void testCheckRemarks() { | ||
| ActionTruncateTables action = new ActionTruncateTables(); | ||
| action.setConnection(null); | ||
|
|
||
| java.util.List<org.apache.hop.core.ICheckResult> remarks = new java.util.ArrayList<>(); | ||
| WorkflowMeta workflowMeta = mock(WorkflowMeta.class); | ||
| when(workflowMeta.findDatabase(any(), any())).thenReturn(null); | ||
|
|
||
| org.apache.hop.core.variables.Variables variables = | ||
| new org.apache.hop.core.variables.Variables(); | ||
| action.check(remarks, workflowMeta, variables, null); | ||
|
|
||
| assertFalse(remarks.isEmpty()); | ||
| assertEquals(org.apache.hop.core.ICheckResult.TYPE_RESULT_WARNING, remarks.get(0).getType()); | ||
| } | ||
|
|
||
| @Test | ||
| void testCheckRemarksWithArgFromPrevious() { | ||
| ActionTruncateTables action = new ActionTruncateTables(); | ||
| action.setArgFromPrevious(true); | ||
| action.setConnection(null); | ||
|
|
||
| java.util.List<org.apache.hop.core.ICheckResult> remarks = new java.util.ArrayList<>(); | ||
| WorkflowMeta workflowMeta = mock(WorkflowMeta.class); | ||
|
|
||
| action.check(remarks, workflowMeta, new org.apache.hop.core.variables.Variables(), null); | ||
|
|
||
| assertFalse(remarks.isEmpty()); | ||
| assertEquals(org.apache.hop.core.ICheckResult.TYPE_RESULT_WARNING, remarks.get(0).getType()); | ||
| } | ||
| } |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[suggestion]
check()warns when no tables are selected, but not when the connection is missing. That is the failure this change fixes at runtime: an action with a table name and an empty connection still passes Verify Workflow and only fails when it runs.workflowMetais unused, so a connection name that is set but no longer in metadata is also ignored.Suggestion: When
Utils.isEmpty(variables.resolve(connection)), orworkflowMeta.findDatabase(...)returns null, add a warning usingActionTruncateTables.NoDbConnection. Do this even whenargFromPreviousis set, because previous rows still need a connection.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done. Updated check() to validate both empty connection and non-existent connection in workflowMeta, showing a warning dialog with NoDbConnection regardless of argFromPrevious.