HIVE-29853: Iceberg CompactionEvaluator double-counts input files - #6737
Open
Aggarwal-Raghav wants to merge 1 commit into
Open
HIVE-29853: Iceberg CompactionEvaluator double-counts input files#6737Aggarwal-Raghav wants to merge 1 commit into
Aggarwal-Raghav wants to merge 1 commit into
Conversation
Aggarwal-Raghav
changed the title
Contributor
Author
|
CC @difin |
Aggarwal-Raghav
commented
Aug 29, 2026
| return false; | ||
| } | ||
|
|
||
| addFiles(); |
Contributor
Author
There was a problem hiding this comment.
addFiles is here as well. So two times counting same data files. To keep the intention of q files same I have just pumped up more inserts to incease the total file size to be eligibe for exception. The failinig q files can be checked in run 1
Aggarwal-Raghav
force-pushed
the
doubleCounting
branch
from
August 29, 2026 08:50
c06e88f to
48e5532
Compare
Aggarwal-Raghav
marked this pull request as ready for review
August 29, 2026 08:50
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Removed the redundant call to
addFiles()from theCompactionEvaluatorconstructor.Why are the changes needed?
The
addFiles()iterates through a table's Iceberg snapshot and adds files to theCommonPartitionEvaluator. Because this was being called in both the constructor and again inisEligibleForCompaction(), every file and byte was double-counted in memory.Does this PR introduce any user-facing change?
Yes. The evaluator will now accurately respect the configured byte sizes and file count thresholds (
compactor.threshold.target.sizeandcompactor.threshold.min.input.files).How was this patch tested?
CI outcome