[server] Fix thread-safety bug in RebalanceManager ZooKeeper recovery path - #4232
Open
fhan688 wants to merge 2 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
RebalanceManager.initialize()is invoked on the startup thread but currently callsregisterRebalance()directly, which mutates non-thread-safe state owned by the coordinator event thread. This violates the single-threaded execution contract and opens a race window during coordinator HA failover or restart.Brief change log
RecoverRebalanceEvent, a new coordinator event that carries theRebalanceTaskread from ZooKeeper during startup recovery.RebalanceManager.initialize()to enqueue aRecoverRebalanceEventviaeventManager.put(...)instead of directly callingregisterRebalance().RecoverRebalanceEventinCoordinatorEventProcessorto delegateregisterRebalance()onto the coordinator event thread.testStartupQueuesRecoverRebalanceEvent, which verifies thatstartup()enqueues the recovery event rather than executing the rebalance inline.Tests
org.apache.fluss.server.coordinator.rebalance.RebalanceManagerTest#testStartupQueuesRecoverRebalanceEvent— verifies the recovery event is enqueued instead of registerRebalance being called inline.RebalanceManagerTestsuite (5 tests) — all pass, no regressions.API and Format
No.
Documentation
No.