[lake/iceberg] Fix Iceberg table rebinding with different Fluss properties - #4220
Open
litiliu wants to merge 1 commit into
Open
[lake/iceberg] Fix Iceberg table rebinding with different Fluss properties#4220litiliu wants to merge 1 commit into
litiliu wants to merge 1 commit into
Conversation
litiliu
marked this pull request as ready for review
September 3, 2026 09:46
luoyuxia
approved these changes
Sep 3, 2026
Contributor
There was a problem hiding this comment.
Warning
Copilot couldn't run its full agentic review because it didn't start before the timeout. Make sure your repository has a runner available, or add a copilot-code-review.yml file specifying one with the runs-on attribute. See the docs for more details.
Pull request overview
Updates Iceberg table compatibility checks to treat Fluss-owned fluss.* metadata as non-blocking during idempotent table creation, while keeping strict validation for Iceberg-native properties.
Changes:
- Skip
fluss.*keys when comparing expected vs existing Iceberg table properties for compatibility. - Add a unit test case asserting that differing
fluss.table.replication.factordoes not mark a table incompatible.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| fluss-lake/fluss-lake-iceberg/src/main/java/org/apache/fluss/lake/iceberg/IcebergLakeCatalog.java | Ignores fluss.* keys during property compatibility checks. |
| fluss-lake/fluss-lake-iceberg/src/test/java/org/apache/fluss/lake/iceberg/IcebergLakeCatalogTest.java | Adds regression coverage for differing Fluss-owned property values. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Comment on lines
+522
to
525
| if (entry.getKey().startsWith(FLUSS_CONF_PREFIX)) { | ||
| continue; | ||
| } | ||
| String actual = existingProperties.get(entry.getKey()); |
Comment on lines
+1778
to
1785
| // Fluss properties are metadata owned by Fluss and may differ between descriptors. | ||
| expected.put("fluss.table.replication.factor", "1"); | ||
| existing.put("fluss.table.replication.factor", "2"); | ||
| assertThat(flussIcebergCatalog.isIcebergPropertiesCompatible(existing, expected)).isTrue(); | ||
|
|
||
| // Existing missing an expected key -> incompatible. | ||
| existing = new HashMap<>(); | ||
| existing.put("k1", "v1"); |
Contributor
Author
|
Thanks @luoyuxia for reviewing and approving this PR! |
litiliu
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
Linked issue: close #4218
Prevent Fluss-owned
fluss.*metadata from making an existing Iceberg table appear incompatible during idempotent table creation. Iceberg-native properties remain strictly validated.Brief change log
fluss.prefix during existing Iceberg table compatibility checks.fluss.table.replication.factor.Tests
./mvnw -q -pl fluss-lake/fluss-lake-iceberg -am -DskipITs -Dtest=IcebergLakeCatalogTest -Dsurefire.failIfNoSpecifiedTests=false testAPI and Format
No API or storage format changes.
Documentation
No documentation changes.
Generative AI disclosure