[metrics] Add per-error TabletServer request metrics - #4213
Open
fxbing wants to merge 1 commit into
Open
Conversation
- Preserve the existing aggregate request metric and API.\n- Lazily register error-scoped meters through MetricGroup.addGroup.\n- Cover the sendError wiring and document the new metric scope.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
Linked issue: close #4212
Expose failed TabletServer RPC requests by error type while preserving the existing aggregate metric.
Brief change log
fluss_tabletserver_request_error_errorsPerSecondmetrics withrequestanderrorlabels.Tests
MetricGroupTest,RequestsMetricsTest,NettyServerHandlerTestspotless:checkand compilation offluss-commonandfluss-rpc/metricssmoke test was not run.API and Format
No public API or storage-format changes.
Documentation
Updated the metrics reference.
Generative AI disclosure