[server] Keep snapshot metrics safe during cleanup - #4089
Merged
platinumhamburg merged 2 commits intoSep 4, 2026
Conversation
platinumhamburg
force-pushed
the
bug-stale-snapshot-metric-red
branch
from
August 25, 2026 01:34
712ac60 to
7108eb2
Compare
platinumhamburg
force-pushed
the
bug-stale-snapshot-metric-red
branch
from
August 25, 2026 01:51
7108eb2 to
22ca7e7
Compare
Jackeyzhe
approved these changes
Sep 4, 2026
Jackeyzhe
left a comment
Jackeyzhe
left a comment
Contributor
There was a problem hiding this comment.
The fix looks good to me. The new test covers both the cleanup failure and the
in-flight gauge collection case for dropping a partition.
Since the production change also reorders metric cleanup in processDropTable,
would it be worth adding the corresponding table-drop failure coverage as well?
This is non-blocking since the two paths are currently symmetric.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
Linked issue: close #4088
Brief change log
Tests
API and Format
Documentation