[flink] Avoid creating empty lake writer in TieringSplitReader#3291
Merged
luoyuxia merged 2 commits intoapache:mainfrom May 9, 2026
Merged
[flink] Avoid creating empty lake writer in TieringSplitReader#3291luoyuxia merged 2 commits intoapache:mainfrom
luoyuxia merged 2 commits intoapache:mainfrom
Conversation
fresh-borzoni
approved these changes
May 9, 2026
Member
fresh-borzoni
left a comment
There was a problem hiding this comment.
+1
nit: just a small regression test will be great, and also I checked quickly SnapshotSplitRecords, it's safe, but relies on BoundedSplitReader logic:
- If a snapshot has zero records, BoundedSplitReader.readBatch() returns null
- if Empty iterator -> writer created, but nothing written. Next call writes records to the same writer, so it's safe
Mb we wish to add the same symmetrical fix there or just leave comment, so that it's less brittle
Contributor
|
LGTM! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
Linked issue: close #3290
Fix a tiering log reader bug where
TieringSplitReadercreates a lake writer before it knows whether the current polled batch contains any record below the splitstoppingOffset.Brief change log
TieringSplitReader.forLogRecordsuntil the first record withrecord.logOffset() < stoppingOffsetis encountered.Tests
./mvnw -pl fluss-flink/fluss-flink-common -DskipTests spotless:check checkstyle:check.API and Format
No API or storage format changes.
Documentation
No documentation changes.