-
Notifications
You must be signed in to change notification settings - Fork 535
[KV] Kvscan Server Side #3151
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
[KV] Kvscan Server Side #3151
Changes from all commits
Commits
Show all changes
17 commits
Select commit
Hold shift + click to select a range
39a3cc5
add configoptions
polyzos 245c5fb
add server side impl
polyzos e289f1a
add documentation for configs
polyzos 62c82a2
make some improvements
polyzos 2f628a7
address copilot suggestions
polyzos 3f8685a
address immutability + leadership-race comments
polyzos 58bfa1f
address ScannerManager / ScannerContext comments
polyzos d5e250f
address TabletService correctness comments
polyzos f249f07
get ConcurrentHashMap from MapUtils and a few other small improvements
polyzos 952a9cc
add more tests to tabletservice
polyzos bcf1357
fix spotless
polyzos 3e04fbe
Serialise scanKv per scannerId; defer TTL refresh until validation; f…
polyzos 25d630c
remove the MapUtils as it was intentionally removed in #3113
polyzos 6748c7f
small improvements and cleanup
polyzos af4e58e
Refactor ScannerManager to manage max batch size for KV scans
wuchong fb0e133
Refactor close method in ScannerContext to use IOUtils for resource m…
wuchong 6b611fb
fix test
wuchong File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
49 changes: 49 additions & 0 deletions
49
fluss-server/src/main/java/org/apache/fluss/server/kv/scan/OpenScanResult.java
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,49 @@ | ||
| /* | ||
| * Licensed to the Apache Software Foundation (ASF) under one or more | ||
| * contributor license agreements. See the NOTICE file distributed with | ||
| * this work for additional information regarding copyright ownership. | ||
| * The ASF licenses this file to You under the Apache License, Version 2.0 | ||
| * (the "License"); you may not use this file except in compliance with | ||
| * the License. You may obtain a copy of the License at | ||
| * | ||
| * http://www.apache.org/licenses/LICENSE-2.0 | ||
| * | ||
| * Unless required by applicable law or agreed to in writing, software | ||
| * distributed under the License is distributed on an "AS IS" BASIS, | ||
| * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| * See the License for the specific language governing permissions and | ||
| * limitations under the License. | ||
| */ | ||
|
|
||
| package org.apache.fluss.server.kv.scan; | ||
|
|
||
| import org.apache.fluss.annotation.Internal; | ||
|
|
||
| import javax.annotation.Nullable; | ||
|
|
||
| /** | ||
| * Result of opening a KV full-scan session: an optional {@link ScannerContext} plus the log offset | ||
| * captured at snapshot time. The offset must reach the client even on the empty-bucket fast path so | ||
| * a snapshot-to-log handoff cannot miss or duplicate records. | ||
| */ | ||
| @Internal | ||
| public final class OpenScanResult { | ||
|
|
||
| @Nullable private final ScannerContext context; | ||
| private final long logOffset; | ||
|
|
||
| public OpenScanResult(@Nullable ScannerContext context, long logOffset) { | ||
| this.context = context; | ||
| this.logOffset = logOffset; | ||
| } | ||
|
|
||
| /** {@code null} if the bucket was empty at snapshot time. */ | ||
| @Nullable | ||
| public ScannerContext getContext() { | ||
| return context; | ||
| } | ||
|
|
||
| public long getLogOffset() { | ||
| return logOffset; | ||
| } | ||
| } |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.