fix: correct SheetWriteHandler.afterSheetDispose to avoid repeated execution

fesod-sheet/src/main/java/org/apache/fesod/sheet/write/ExcelBuilderImpl.java

@@ -81,8 +81,6 @@ public void addContent(Collection<?> data, WriteSheet writeSheet, WriteTable wri
                 excelWriteAddExecutor = new ExcelWriteAddExecutor(context);
             }
             excelWriteAddExecutor.add(data);
-            // execute callback after the sheet is written
-            WriteHandlerUtils.afterSheetDispose(context);
         } catch (RuntimeException e) {
             finishOnException();
             throw e;
@@ -106,8 +104,6 @@ public void fill(Object data, FillConfig fillConfig, WriteSheet writeSheet) {
                 excelWriteFillExecutor = new ExcelWriteFillExecutor(context);
             }
             excelWriteFillExecutor.fill(data, fillConfig);
-            // execute callback after the sheet is written
-            WriteHandlerUtils.afterSheetDispose(context);
         } catch (RuntimeException e) {
             finishOnException();
             throw e;
@@ -124,6 +120,9 @@ private void finishOnException() {
     @Override
     public void finish(boolean onException) {
         if (context != null) {
+            // executes the callback after the current sheet has been fully written.
+            WriteHandlerUtils.afterSheetDispose(context);
+
             context.finish(onException);
         }
     }

fesod-sheet/src/test/java/org/apache/fesod/sheet/handler/CountingWriteHandler.java

@@ -0,0 +1,196 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements.  See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership.  The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License.  You may obtain a copy of the License at
+ *
+ *   http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied.  See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+
+package org.apache.fesod.sheet.handler;
+
+import java.util.List;
+import org.apache.fesod.sheet.metadata.Head;
+import org.apache.fesod.sheet.metadata.data.WriteCellData;
+import org.apache.fesod.sheet.write.handler.CellWriteHandler;
+import org.apache.fesod.sheet.write.handler.RowWriteHandler;
+import org.apache.fesod.sheet.write.handler.SheetWriteHandler;
+import org.apache.fesod.sheet.write.handler.WorkbookWriteHandler;
+import org.apache.fesod.sheet.write.handler.context.SheetWriteHandlerContext;
+import org.apache.fesod.sheet.write.metadata.holder.WriteSheetHolder;
+import org.apache.fesod.sheet.write.metadata.holder.WriteTableHolder;
+import org.apache.fesod.sheet.write.metadata.holder.WriteWorkbookHolder;
+import org.apache.poi.ss.usermodel.Cell;
+import org.apache.poi.ss.usermodel.Row;
+import org.junit.jupiter.api.Assertions;
+
+public class CountingWriteHandler
+        implements WorkbookWriteHandler, SheetWriteHandler, RowWriteHandler, CellWriteHandler {
+
+    private final long headCount;
+    private final long dataCount;
+
+    private long beforeCellCreate = 0L;
+    private long afterCellCreate = 0L;
+    private long afterCellDataConverted = 0L;
+    private long afterCellDispose = 0L;
+    private long beforeRowCreate = 0L;
+    private long afterRowCreate = 0L;
+    private long afterRowDispose = 0L;
+    private long beforeSheetCreate = 0L;
+    private long afterSheetCreate = 0L;
+    private long afterSheetDispose = 0L;
+    private long beforeWorkbookCreate = 0L;
+    private long afterWorkbookCreate = 0L;
+    private long afterWorkbookDispose = 0L;
+
+    public CountingWriteHandler(long headCount, long dataCount) {
+        this.headCount = headCount;
+        this.dataCount = dataCount;
+    }
+
+    @Override
+    public void beforeCellCreate(
+            WriteSheetHolder writeSheetHolder,
+            WriteTableHolder writeTableHolder,
+            Row row,
+            Head head,
+            Integer columnIndex,
+            Integer relativeRowIndex,
+            Boolean isHead) {
+        if (isHead) {
+            beforeCellCreate++;
+        }
+    }
+
+    @Override
+    public void afterCellCreate(
+            WriteSheetHolder writeSheetHolder,
+            WriteTableHolder writeTableHolder,
+            Cell cell,
+            Head head,
+            Integer relativeRowIndex,
+            Boolean isHead) {
+        if (isHead) {
+            afterCellCreate++;
+        }
+    }
+
+    @Override
+    public void afterCellDataConverted(
+            WriteSheetHolder writeSheetHolder,
+            WriteTableHolder writeTableHolder,
+            WriteCellData<?> cellData,
+            Cell cell,
+            Head head,
+            Integer relativeRowIndex,
+            Boolean isHead) {
+        afterCellDataConverted++;
+    }
+
+    @Override
+    public void afterCellDispose(
+            WriteSheetHolder writeSheetHolder,
+            WriteTableHolder writeTableHolder,
+            List<WriteCellData<?>> cellDataList,
+            Cell cell,
+            Head head,
+            Integer relativeRowIndex,
+            Boolean isHead) {
+        if (isHead) {
+            afterCellDispose++;
+        }
+    }
+
+    @Override
+    public void beforeRowCreate(
+            WriteSheetHolder writeSheetHolder,
+            WriteTableHolder writeTableHolder,
+            Integer rowIndex,
+            Integer relativeRowIndex,
+            Boolean isHead) {
+        if (isHead) {
+            beforeRowCreate++;
+        }
+    }
+
+    @Override
+    public void afterRowCreate(
+            WriteSheetHolder writeSheetHolder,
+            WriteTableHolder writeTableHolder,
+            Row row,
+            Integer relativeRowIndex,
+            Boolean isHead) {
+        if (isHead) {
+            afterRowCreate++;
+        }
+    }
+
+    @Override
+    public void afterRowDispose(
+            WriteSheetHolder writeSheetHolder,
+            WriteTableHolder writeTableHolder,
+            Row row,
+            Integer relativeRowIndex,
+            Boolean isHead) {
+        if (isHead) {
+            afterRowDispose++;
+        }
+    }
+
+    @Override
+    public void beforeSheetCreate(WriteWorkbookHolder writeWorkbookHolder, WriteSheetHolder writeSheetHolder) {
+        beforeSheetCreate++;
+    }
+
+    @Override
+    public void afterSheetCreate(WriteWorkbookHolder writeWorkbookHolder, WriteSheetHolder writeSheetHolder) {
+        afterSheetCreate++;
+    }
+
+    @Override
+    public void beforeWorkbookCreate() {
+        beforeWorkbookCreate++;
+    }
+
+    @Override
+    public void afterWorkbookCreate(WriteWorkbookHolder writeWorkbookHolder) {
+        afterWorkbookCreate++;
+    }
+
+    @Override
+    public void afterWorkbookDispose(WriteWorkbookHolder writeWorkbookHolder) {
+        afterWorkbookDispose++;
+    }
+
+    @Override
+    public void afterSheetDispose(SheetWriteHandlerContext context) {
+        afterSheetDispose++;
+    }
+
+    public void afterAll() {
+        Assertions.assertEquals(headCount, beforeCellCreate);
+        Assertions.assertEquals(headCount, afterCellCreate);
+        Assertions.assertEquals(dataCount, afterCellDataConverted);
+        Assertions.assertEquals(headCount, afterCellDispose);
+        Assertions.assertEquals(headCount, beforeRowCreate);
+        Assertions.assertEquals(headCount, afterRowCreate);
+        Assertions.assertEquals(headCount, afterRowDispose);
+        Assertions.assertEquals(1L, beforeSheetCreate);
+        Assertions.assertEquals(1L, afterSheetCreate);
+        Assertions.assertEquals(1L, beforeWorkbookCreate);
+        Assertions.assertEquals(1L, afterWorkbookCreate);
+        Assertions.assertEquals(1L, afterWorkbookDispose);
+        Assertions.assertEquals(1L, afterSheetDispose);
+    }
+}