Skip to content

[feature] [transform] add new aggregate transform and id transform #16903

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
pissang wants to merge 11 commits into
base: next
Choose a base branch
from
Draft

[feature] [transform] add new aggregate transform and id transform #16903

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
ff53c0d
chore: fix map data decode util
pissang Mar 16, 2022
f6a7c3a
feat(transform): introduce aggregate and id transform
pissang Mar 18, 2022
63c1da2
feat(transform): refact aggregate transform
pissang Mar 23, 2022
4b11232
fix wrong import
pissang Mar 23, 2022
6b4b944
style: optimize code
pissang Mar 23, 2022
197e3b3
feat(transform): support multiple groupBy in aggregate
pissang Mar 23, 2022
aa700ef
feat(transform): use val directly in groupBy dimension result
pissang Mar 23, 2022
72e29af
refact(dataset): rename seriesLayoutBy to sourceLayout
pissang Mar 24, 2022
e69a6f4
fix(transform): fix count aggregate. clean codes
pissang Mar 25, 2022
7f14e94
fix(dataset): fix using transform in dataset may cause dead loop.
pissang Apr 14, 2022
93ff271
test(dataset): fix unit test after changing from seriesLayoutBy to so…
pissang Apr 18, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/chart/pie/PieView.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -95,7 +95,7 @@ class PiePiece extends graphic.Sector {
}
}, seriesModel, idx);
}
// Expansion
// Expansion.
else {
if (startAngle != null) {
sector.setShape({ startAngle, endAngle: startAngle });
Expand Down
14 changes: 10 additions & 4 deletions src/component/dataset/install.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,8 +29,8 @@
import ComponentModel from '../../model/Component';
import ComponentView from '../../view/Component';
import {
SERIES_LAYOUT_BY_COLUMN, ComponentOption, SeriesEncodeOptionMixin,
OptionSourceData, SeriesLayoutBy, OptionSourceHeader
SOURCE_LAYOUT_BY_COLUMN, ComponentOption, SeriesEncodeOptionMixin,
OptionSourceData, SourceLayout, OptionSourceHeader
} from '../../util/types';
import { DataTransformOption, PipedDataTransformOption } from '../../data/helper/transform';
import GlobalModel from '../../model/Global';
Expand All @@ -44,10 +44,16 @@ export interface DatasetOption extends
Pick<SeriesEncodeOptionMixin, 'dimensions'> {
mainType?: 'dataset';

seriesLayoutBy?: SeriesLayoutBy;
sourceLayout?: SourceLayout;
sourceHeader?: OptionSourceHeader;
source?: OptionSourceData;

/**
* @deprecated
* Use sourceLayout instead
*/
seriesLayoutBy?: SourceLayout

fromDatasetIndex?: number;
fromDatasetId?: string;
transform?: DataTransformOption | PipedDataTransformOption;
Expand All @@ -63,7 +69,7 @@ export class DatasetModel<Opts extends DatasetOption = DatasetOption> extends Co
static type = 'dataset';

static defaultOption: DatasetOption = {
seriesLayoutBy: SERIES_LAYOUT_BY_COLUMN
sourceLayout: SOURCE_LAYOUT_BY_COLUMN
};

private _sourceManager: SourceManager;
Expand Down
Loading