Skip to content

fix: synchronize GraalVM JavaScript context access in JavaScriptTieredBrokerSelectorStrategy (#18253) [fj4WqyCCw3C5ShR1RfB7MoBPTpkRrBFYP1uT35g3MvT] #19856

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
waterWang wants to merge 1 commit into
base: master
Choose a base branch
from
+4 −2
Open

fix: synchronize GraalVM JavaScript context access in JavaScriptTieredBrokerSelectorStrategy (#18253) [fj4WqyCCw3C5ShR1RfB7MoBPTpkRrBFYP1uT35g3MvT] #19856

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions .../src/main/java/org/apache/druid/server/router/JavaScriptTieredBrokerSelectorStrategy.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -53,9 +53,11 @@ public JavaScriptTieredBrokerSelectorStrategy(
}

@Override
public Optional<String> getBrokerServiceName(TieredBrokerConfig config, Query query)
public synchronized Optional<String> getBrokerServiceName(TieredBrokerConfig config, Query query)

@FrankChen021 FrankChen021 Aug 2, 2026 •
edited
Loading

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Although Codex reports 'LGTM', I have different opinons.

If you look at the usage of compileSelectorFunction, there's another place that uses it, and the 'synchronized' is not added. So adding 'synchronized' to caller is not good, we may forget to add it in new places.

As this is due to script engine layer problem, I think it's the compileSelectorFunction that ensures that the returned fnSelector is a concurrent safe version.

One way is that we can use dynamic proxy inside compileSelectorFunction to wrap existing object and forward the call in a synchronized block

{
fnSelector = fnSelector == null ? JavaScriptUtil.compileSelectorFunction(SelectorFunction.class, function) : fnSelector;
if (fnSelector == null) {
fnSelector = JavaScriptUtil.compileSelectorFunction(SelectorFunction.class, function);
}
return Optional.fromNullable(fnSelector.apply(config, query));
}

Expand Down
Loading