fix: correct the copy-pasted docs for covar_pop and bool_or - #24990
Open
jackylee-ch wants to merge 1 commit into
Open
fix: correct the copy-pasted docs for covar_pop and bool_or#24990jackylee-ch wants to merge 1 commit into
jackylee-ch wants to merge 1 commit into
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #24990 +/- ##
==========================================
- Coverage 81.67% 81.66% -0.01%
==========================================
Files 1126 1126
Lines 414524 414524
Branches 414524 414524
==========================================
- Hits 338558 338541 -17
- Misses 56054 56065 +11
- Partials 19912 19918 +6 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Rationale for this change
The
user_docblocks forcovar_popandbool_orare verbatim copies ofcovar_sampandbool_and, so the SQL reference documents the wrong function.covar_popis described as sample covariance, andbool_oras "true if all non-null input values are true" — the inverse of what it does.Existing tests already show the behaviour differs:
aggregate.sltgivescovar_samp = 1vscovar_pop = 0.666666666667on the same data, andbool_and = falsevsbool_or = trueon the same column.What changes are included in this PR?
Corrects the description,
syntax_exampleandsql_exampleof both, and regeneratesaggregate_functions.md.What is the testing strategy for this PR?
Docs only; the behaviour is unchanged and already covered by the
aggregate.sltcases cited above.Are there any user-facing changes?
The SQL reference for
covar_popandbool_oris now correct. No API change.