Skip to content

fix: correct the copy-pasted docs for covar_pop and bool_or - #24990

Open
jackylee-ch wants to merge 1 commit into
apache:mainfrom
jackylee-ch:fix-copy-pasted-aggregate-docs
Open

fix: correct the copy-pasted docs for covar_pop and bool_or#24990
jackylee-ch wants to merge 1 commit into
apache:mainfrom
jackylee-ch:fix-copy-pasted-aggregate-docs

Conversation

@jackylee-ch

Copy link
Copy Markdown
Contributor

Which issue does this PR close?

  • N/A

Rationale for this change

The user_doc blocks for covar_pop and bool_or are verbatim copies of covar_samp and bool_and, so the SQL reference documents the wrong function. covar_pop is described as sample covariance, and bool_or as "true if all non-null input values are true" — the inverse of what it does.

Existing tests already show the behaviour differs: aggregate.slt gives covar_samp = 1 vs covar_pop = 0.666666666667 on the same data, and bool_and = false vs bool_or = true on the same column.

What changes are included in this PR?

Corrects the description, syntax_example and sql_example of both, and regenerates aggregate_functions.md.

What is the testing strategy for this PR?

Docs only; the behaviour is unchanged and already covered by the aggregate.slt cases cited above.

Are there any user-facing changes?

The SQL reference for covar_pop and bool_or is now correct. No API change.

@github-actions github-actions Bot added documentation Improvements or additions to documentation functions Changes to functions implementation labels Sep 6, 2026
@codecov-commenter

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 81.66%. Comparing base (5b389eb) to head (9dda3be).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #24990      +/-   ##
==========================================
- Coverage   81.67%   81.66%   -0.01%     
==========================================
  Files        1126     1126              
  Lines      414524   414524              
  Branches   414524   414524              
==========================================
- Hits       338558   338541      -17     
- Misses      56054    56065      +11     
- Partials    19912    19918       +6     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Improvements or additions to documentation functions Changes to functions implementation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants