fix: accept an empty flags string in regexp_replace - #24987
Open
jackylee-ch wants to merge 1 commit into
Open
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #24987 +/- ##
==========================================
- Coverage 81.67% 81.67% -0.01%
==========================================
Files 1126 1126
Lines 414524 414545 +21
Branches 414524 414545 +21
==========================================
+ Hits 338558 338571 +13
- Misses 56054 56057 +3
- Partials 19912 19917 +5 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Rationale for this change
regexp_replace('foobarbaz', 'b..', 'X', '')errors withregex parse error: (?)binstead of returningfooXbaz.regexp_countandregexp_instraccept an empty flags string throughcompile_regex, and so does Postgres.'gg'hits the same error, since strippinggleaves an empty flags string.What changes are included in this PR?
Both call sites omit the
(?flags)prefix when no flags remain aftergis stripped, matchingcompile_regexin the same module.What is the testing strategy for this PR?
Three queries in
regexp_replace.sltand two unit tests inregexpreplace.rs. All of them fail onmainwithrepetition operator missing expressionand pass with this change.Are there any user-facing changes?
regexp_replacewith an empty flags string now replaces instead of erroring. No API change.