Fix Postgres decimal formatter clippy - #24975
Open
osipovartem wants to merge 2 commits into
Open
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #24975 +/- ##
==========================================
- Coverage 81.67% 81.67% -0.01%
==========================================
Files 1126 1126
Lines 414842 414842
Branches 414842 414842
==========================================
- Hits 338841 338832 -9
- Misses 56070 56077 +7
- Partials 19931 19933 +2 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
osipovartem
force-pushed
the
upstream-slt-decimal-clippy
branch
from
September 6, 2026 16:39
b7fb5cf to
c25d58a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Rationale for this change
The required
cargo clippy --all-targets --all-features -- -D warningscommand fails because the PostgreSQL result formatter takes aBigDecimalby value but only reads it.What changes are included in this PR?
&BigDecimalindecimal_to_str.postgresfeature.What is the testing strategy for this PR?
cargo test -p datafusion-sqllogictest --lib --features postgres engines::conversioncargo clippy --all-targets --all-features -- -D warningscargo fmt --all -- --checkAre there any user-facing changes?
No. The formatted PostgreSQL decimal output is unchanged.