test: consolidate ASOF SQL coverage - #24964
Draft
Xuanwo wants to merge 10 commits into
Draft
Conversation
# Conflicts: # datafusion/expr/src/logical_plan/builder.rs # datafusion/expr/src/logical_plan/plan.rs
|
Thank you for opening this pull request! Reviewer note: cargo-semver-checks reported the current version number is not SemVer-compatible with the changes in this pull request (compared against the base branch). Details |
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #24964 +/- ##
==========================================
+ Coverage 81.57% 81.68% +0.10%
==========================================
Files 1123 1124 +1
Lines 410789 413484 +2695
Branches 410789 413484 +2695
==========================================
+ Hits 335120 337756 +2636
+ Misses 55913 55833 -80
- Partials 19756 19895 +139 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Rationale for this change
ASOF SQL behavior was split between sqllogictest and Rust integration tests. SQL-level results and plan shapes are easier to review and maintain in SLT, while Rust coverage remains useful for setup that SLT cannot express.
GitHub shows the cumulative stack because fork branches cannot be selected as upstream PR bases. The isolated diff is:
Xuanwo/datafusion@xuanwo/asof-sql...xuanwo/asof-slt-coverage
What changes are included in this PR?
asof_join.slt.USING.Are these changes tested?
Yes:
cargo fmt --allcargo clippy --all-targets --all-features -- -D warningscargo test -p datafusion-sqllogictest --test sqllogictests --all-features -- asof_joincargo test -p datafusion --test core_integration asof --all-featuresAre there any user-facing changes?
No. This consolidates and expands coverage for the ASOF SQL contract introduced by #23830.