aggregate blocked impl - #24928
Conversation
…so all usages will be migrated
…ockedGroupColumn`
…e grouped_hash_stream code
# Conflicts: # datafusion/expr-common/src/groups_accumulator.rs
|
🤖 Benchmark running (GKE) | trigger CPU Details (lscpu)Comparing add-blocks-impl-from-scratch (5870a0d) to 5bf6aef (merge-base) diff Run configurationrun benchmark tpcdsResults will be posted here when complete File an issue against this benchmark runner |
|
🤖 Benchmark running (GKE) | trigger CPU Details (lscpu)Comparing add-blocks-impl-from-scratch (5870a0d) to 5bf6aef (merge-base) diff Run configurationrun benchmark tpchResults will be posted here when complete File an issue against this benchmark runner |
|
🤖 Benchmark completed (GKE) | trigger Instance: Comparing add-blocks-impl-from-scratch (1a44055) to 5bf6aef (merge-base) diff Run configurationrun benchmark external_aggrCPU Details (lscpu)Details
Memory Pool PeaksPeak Base:
Pool accounting vs. process RSS Max pool peak is the largest reservation any single query in the run reached; peak RSS covers the whole invocation, including data loading and allocator retention, and the two high-water marks need not coincide in time. The gap is therefore an upper bound on what the pool did not account for, not a measurement of it.
Resource Usageexternal_aggr — base (merge-base)
external_aggr — branch
File an issue against this benchmark runner |
|
🤖 Benchmark completed (GKE) | trigger Instance: Comparing add-blocks-impl-from-scratch (5870a0d) to 5bf6aef (merge-base) diff Run configurationrun benchmark h2o_smallCPU Details (lscpu)Details
Resource Usageh2o_small — base (merge-base)
h2o_small — branch
File an issue against this benchmark runner |
|
🤖 Benchmark completed (GKE) | trigger Instance: Comparing add-blocks-impl-from-scratch (5870a0d) to 5bf6aef (merge-base) diff Run configurationrun benchmark tpchCPU Details (lscpu)Details
Resource Usagetpch — base (merge-base)
tpch — branch
File an issue against this benchmark runner |
|
🤖 Benchmark completed (GKE) | trigger Instance: Comparing add-blocks-impl-from-scratch (5870a0d) to 5bf6aef (merge-base) diff Run configurationrun benchmark tpcdsCPU Details (lscpu)Details
Resource Usagetpcds — base (merge-base)
tpcds — branch
File an issue against this benchmark runner |
|
🤖 Benchmark completed (GKE) | trigger Instance: Comparing add-blocks-impl-from-scratch (5870a0d) to 5bf6aef (merge-base) diff Run configurationrun benchmark clickbench_partitionedCPU Details (lscpu)Details
Resource Usageclickbench_partitioned — base (merge-base)
clickbench_partitioned — branch
File an issue against this benchmark runner |
|
🤖 Benchmark completed (GKE) | trigger Instance: Comparing add-blocks-impl-from-scratch (5870a0d) to 5bf6aef (merge-base) diff Run configurationrun benchmark h2o_mediumCPU Details (lscpu)Details
Resource Usageh2o_medium — base (merge-base)
h2o_medium — branch
File an issue against this benchmark runner |
|
🤖 Benchmark completed (GKE) | trigger Instance: Comparing add-blocks-impl-from-scratch (5870a0d) to 5bf6aef (merge-base) diff Run configurationrun benchmark external_aggrCPU Details (lscpu)Details
Memory Pool PeaksPeak Base:
Pool accounting vs. process RSS Max pool peak is the largest reservation any single query in the run reached; peak RSS covers the whole invocation, including data loading and allocator retention, and the two high-water marks need not coincide in time. The gap is therefore an upper bound on what the pool did not account for, not a measurement of it.
Resource Usageexternal_aggr — base (merge-base)
external_aggr — branch
File an issue against this benchmark runner |
…crease mmap address space so we don't need to reallocate often
…, and increase mmap address space so we don't need to reallocate often" This reverts commit a25342b.
|
run benchmark h2o_small h2o_medium external_aggr |
|
run benchmarks |
|
🤖 Benchmark running (GKE) | trigger CPU Details (lscpu)Comparing add-blocks-impl-from-scratch (10864ee) to 5bf6aef (merge-base) diff Run configurationrun benchmark h2o_smallResults will be posted here when complete File an issue against this benchmark runner |
|
🤖 Benchmark running (GKE) | trigger CPU Details (lscpu)Comparing add-blocks-impl-from-scratch (10864ee) to 5bf6aef (merge-base) diff Run configurationrun benchmark tpcdsResults will be posted here when complete File an issue against this benchmark runner |
|
🤖 Benchmark running (GKE) | trigger CPU Details (lscpu)Comparing add-blocks-impl-from-scratch (10864ee) to 5bf6aef (merge-base) diff Run configurationrun benchmark tpchResults will be posted here when complete File an issue against this benchmark runner |
|
🤖 Benchmark running (GKE) | trigger CPU Details (lscpu)Comparing add-blocks-impl-from-scratch (10864ee) to 5bf6aef (merge-base) diff Run configurationrun benchmark h2o_mediumResults will be posted here when complete File an issue against this benchmark runner |
|
🤖 Benchmark running (GKE) | trigger CPU Details (lscpu)Comparing add-blocks-impl-from-scratch (10864ee) to 5bf6aef (merge-base) diff Run configurationrun benchmark external_aggrResults will be posted here when complete File an issue against this benchmark runner |
|
🤖 Benchmark running (GKE) | trigger CPU Details (lscpu)Comparing add-blocks-impl-from-scratch (10864ee) to 5bf6aef (merge-base) diff Run configurationrun benchmark clickbench_partitionedResults will be posted here when complete File an issue against this benchmark runner |
|
🤖 Benchmark completed (GKE) | trigger Instance: Comparing add-blocks-impl-from-scratch (10864ee) to 5bf6aef (merge-base) diff Run configurationrun benchmark tpchCPU Details (lscpu)Details
Resource Usagetpch — base (merge-base)
tpch — branch
File an issue against this benchmark runner |
|
🤖 Benchmark completed (GKE) | trigger Instance: Comparing add-blocks-impl-from-scratch (10864ee) to 5bf6aef (merge-base) diff Run configurationrun benchmark h2o_smallCPU Details (lscpu)Details
Resource Usageh2o_small — base (merge-base)
h2o_small — branch
File an issue against this benchmark runner |
|
🤖 Benchmark completed (GKE) | trigger Instance: Comparing add-blocks-impl-from-scratch (10864ee) to 5bf6aef (merge-base) diff Run configurationrun benchmark tpcdsCPU Details (lscpu)Details
Resource Usagetpcds — base (merge-base)
tpcds — branch
File an issue against this benchmark runner |
|
🤖 Benchmark completed (GKE) | trigger Instance: Comparing add-blocks-impl-from-scratch (10864ee) to 5bf6aef (merge-base) diff Run configurationrun benchmark clickbench_partitionedCPU Details (lscpu)Details
Resource Usageclickbench_partitioned — base (merge-base)
clickbench_partitioned — branch
File an issue against this benchmark runner |
|
🤖 Benchmark completed (GKE) | trigger Instance: Comparing add-blocks-impl-from-scratch (10864ee) to 5bf6aef (merge-base) diff Run configurationrun benchmark h2o_mediumCPU Details (lscpu)Details
Resource Usageh2o_medium — base (merge-base)
h2o_medium — branch
File an issue against this benchmark runner |
|
🤖 Benchmark completed (GKE) | trigger Instance: Comparing add-blocks-impl-from-scratch (10864ee) to 5bf6aef (merge-base) diff Run configurationrun benchmark external_aggrCPU Details (lscpu)Details
Memory Pool PeaksPeak Base:
Pool accounting vs. process RSS Max pool peak is the largest reservation any single query in the run reached; peak RSS covers the whole invocation, including data loading and allocator retention, and the two high-water marks need not coincide in time. The gap is therefore an upper bound on what the pool did not account for, not a measurement of it.
Resource Usageexternal_aggr — base (merge-base)
external_aggr — branch
File an issue against this benchmark runner |
Huge blocked impl that is backwards compatible
And just see the performance cost
Currently it only contain blocked impl for single group by and some aggregate expression
Which issue does this PR close?
Rationale for this change
What changes are included in this PR?
What is the testing strategy for this PR?
Are there any user-facing changes?