Extend sqllogictest framework to uptake custom datafusion.format.* settings#21577
Open
erenavsarogullari wants to merge 1 commit intoapache:mainfrom
Conversation
Member
Author
|
@alamb This PR aims to fix #21355 (comment). It is ready for the review when you have chance. Thanks in advance. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
sqllogictestframework to uptake customdatafusion.format.*settings #21447.Rationale for this change
Ref Discussion: #21355 (comment)
Currently, sqllogictest framework does not support custom datafusion.format.* configs updates and it always runs the tests with default format settings and the results as follows:
Current Behavior:
What is the root-cause of this problem?
The reason is that
sqllogictestframework needs to be extended in order to uptakedatafusion.format.*settings bySessionContextinstead default format settings: https://github.com/apache/datafusion/blob/main/datafusion/sqllogictest/src/engines/datafusion_engine/normalize.rs#L239 like following expected behavior. This ticket aims to address this improvement and add additional functional coverages fordatafusion.format.*configs for the custom settings.Expected Behavior:
What changes are included in this PR?
This PR extends
sqllogictestframework to uptake customdatafusion.format.*settings and adds comprehensive test coverage fordatafusion.format.*configurations.Are these changes tested?
Yes, by adding comprehensive test coverage for
datafusion.format.*configurations.Are there any user-facing changes?
No