chore: add count distinct group benchmarks#21575
Open
coderfender wants to merge 3 commits intoapache:mainfrom
Open
chore: add count distinct group benchmarks#21575coderfender wants to merge 3 commits intoapache:mainfrom
coderfender wants to merge 3 commits intoapache:mainfrom
Conversation
coderfender
force-pushed
the
add_group_benchmarks_count_distinct
branch
from
9413a74 to
bacee66
Compare
coderfender
force-pushed
the
add_group_benchmarks_count_distinct
branch
from
3abdd0d to
45a19b0
Compare
Contributor
Author
|
@Dandandan , I plan to add benches to help better evaluate group accumulators along with direct clickbench / TPCH queries for implementing group accumulators . Please take a look whenever you get a chance |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Add benchmarks for group accumulators to test : #21561
The implementation forks out based on
is_groups_accumulator_supportedfunction call. Once this is merged , we should be able to evaluate group accumulators on count distinct exprRationale for this change
What changes are included in this PR?
Are these changes tested?
Are there any user-facing changes?