Remove as_any on the PhysicalExpr trait#21573
Open
timsaucer wants to merge 3 commits intoapache:mainfrom
Open
Conversation
Leverage Rust 1.86 trait upcasting to remove the `as_any` boilerplate from `PhysicalExpr`, following the same pattern as apache#21346 which did this for `TableProvider`, `SchemaProvider`, `CatalogProvider`, and `CatalogProviderList`. Since `PhysicalExpr: Any`, Rust can now upcast `&dyn PhysicalExpr` to `&dyn Any` directly. This adds `is` and `downcast_ref` convenience methods on `impl dyn PhysicalExpr` and removes `fn as_any` from the trait and all 24 implementors. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
github-actions
bot
added
documentation
timsaucer
commented
Apr 12, 2026
Comment on lines
-942
to
-951
| Field::new( | ||
| left_col.as_any().downcast_ref::<Column>().unwrap().name(), | ||
| DataType::Int32, | ||
| true, | ||
| ), | ||
| Field::new( | ||
| right_col.as_any().downcast_ref::<Column>().unwrap().name(), | ||
| DataType::Int32, | ||
| true, | ||
| ), |
Member
Author
There was a problem hiding this comment.
It looks at first glance like we're removing a check on the Column type but if you look higher up you can see that left_col is an Arc<Column> so this doesn't impact the test.
timsaucer
commented
Apr 12, 2026
| let literal_expr = lit(10i64); | ||
| let binary_expr = | ||
| Arc::new(BinaryExpr::new(cast_expr, Operator::Gt, literal_expr)); | ||
| let binary_ref = binary_expr.as_any().downcast_ref::<BinaryExpr>().unwrap(); |
Member
Author
There was a problem hiding this comment.
Similar to above, this test didn't really do anything other than step through the as_any() function since binary_expr is already an Arc<BinaryExpr>
16 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
as_anyfrom trait definitions #21572Rationale for this change
This PR reduces the amount of boilerplate code that users need to write for Physical Expressions.
What changes are included in this PR?
Now that we have trait upcasting since rust 1.86, we no longer need every implementation of this trait to have the as_any function that returns &self. This PR makes Any an supertrait and makes the appropriate casts when necessary.
Are these changes tested?
Existing unit tests.
Are there any user-facing changes?
Yes, the users simply need to remove the as_any function. The upgrade guide is updated.