Skip to content

PostgreSQL: Parse REVOKE of role membership - #2735

Open
LucaCappelletti94 wants to merge 2 commits into
mainfrom
upstream/postgres-revoke-role-membership
Open

LucaCappelletti94 wants to merge 2 commits into
mainfrom
upstream/postgres-revoke-role-membership

Conversation

@LucaCappelletti94

Copy link
Copy Markdown
Contributor

REVOKE bypasser FROM anon failed with Expected: a privilege keyword, found: bypasser, since REVOKE only knew the privilege form. PostgreSQL revokes a role membership by naming the role without a keyword (REVOKE).

The statement now parses into a new Statement::RevokeRole with GRANTED BY and CASCADE or RESTRICT. It goes through the same privilege-first fallback as the role membership GRANT, so existing statements and their errors are unchanged.

@codecov-commenter

codecov-commenter commented Oct 27, 2026 •

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 97.36842% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 82.40%. Comparing base (14eadef) to head (835ae9a).
⚠️ Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
src/ast/spans.rs 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2735      +/-   ##
==========================================
+ Coverage   82.38%   82.40%   +0.01%     
==========================================
  Files          42       42              
  Lines       35339    35376      +37     
  Branches    35339    35376      +37     
==========================================
+ Hits        29115    29151      +36     
- Misses       2678     2679       +1     
  Partials     3546     3546              

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@LucaCappelletti94 LucaCappelletti94 added the enhancement New feature or request label Oct 27, 2026
@LucaCappelletti94
LucaCappelletti94 force-pushed the upstream/postgres-revoke-role-membership branch from bf4626d to db5901d Compare October 28, 2026 07:51
@LucaCappelletti94
LucaCappelletti94 force-pushed the upstream/postgres-revoke-role-membership branch from db5901d to dcfcf7a Compare October 28, 2026 11:29
@LucaCappelletti94
LucaCappelletti94 deleted the branch upstream/postgres-grant-role-membership October 28, 2026 11:30
Base automatically changed from upstream/postgres-grant-role-membership to main October 28, 2026 11:30
@LucaCappelletti94
LucaCappelletti94 force-pushed the upstream/postgres-revoke-role-membership branch from dcfcf7a to 835ae9a Compare October 28, 2026 11:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request PostgreSQL

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants