Repository navigation
Conversation
Capture the Dialect method signatures while compiling sqlparser so expansion needs no source files or embedded build directory. Preserve invocation-site parameter names for expression overrides. Exercise all public entry points after removing the dependency sources. Direct macro callers now need sqlparser with derive-dialect or visitor. Fixes apache#2724
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
derive_dialect!reads sqlparser's source tree during expansion and embedsits own build directory in the proc-macro binary. Expansion fails when
only compiled dependencies are available.
Dialectsignatures in sqlparser and pass them as macro tokens.Direct
sqlparser_derive::derive_dialect!callers must enable sqlparser'sderive-dialectfeature (orvisitor). Both crates need coordinatedreleases: the new derive macro requires sqlparser's new helper.
Fixes #2724
Dialects: none
Prepared with Codex.