Skip to content

PostgreSQL: Share operator-purpose parsing - #2719

Merged
LucaCappelletti94 merged 1 commit into
mainfrom
share-operator-purpose-parsing
Oct 26, 2026
Merged

LucaCappelletti94 merged 1 commit into
mainfrom
share-operator-purpose-parsing

Conversation

@LucaCappelletti94

Copy link
Copy Markdown
Contributor

CREATE OPERATOR CLASS and ALTER OPERATOR FAMILY ... ADD OPERATOR share one private parser for optional FOR SEARCH and FOR ORDER BY clauses and their diagnostics.

Addresses the operator-purpose parsing duplication tracked in #2698.

Yet another echoes find.

@LucaCappelletti94 LucaCappelletti94 added rust Pull requests that update rust code PostgreSQL deduplication Removal of duplicated code labels Oct 25, 2026
@codecov-commenter

codecov-commenter commented Oct 25, 2026 •

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 92.30769% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 82.30%. Comparing base (49033b0) to head (d34dcb3).

Files with missing lines Patch % Lines
src/parser/mod.rs 92.30% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2719   +/-   ##
=======================================
  Coverage   82.29%   82.30%           
=======================================
  Files          42       42           
  Lines       35315    35311    -4     
  Branches    35315    35311    -4     
=======================================
  Hits        29061    29061           
+ Misses       2695     2692    -3     
+ Partials     3559     3558    -1     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@LucaCappelletti94
LucaCappelletti94 force-pushed the share-operator-purpose-parsing branch from fddcfae to d34dcb3 Compare October 26, 2026 18:58
@LucaCappelletti94

Copy link
Copy Markdown
Contributor Author

cc @alamb merging also this echo

@LucaCappelletti94
LucaCappelletti94 added this pull request to the merge queue Oct 26, 2026
Merged via the queue into main with commit 583c4d4 Oct 26, 2026
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

deduplication Removal of duplicated code PostgreSQL rust Pull requests that update rust code

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants