Skip to content

MySQL, Spark: Share DIV parsing - #2718

Merged
LucaCappelletti94 merged 1 commit into
mainfrom
share-div-infix-parsing
Oct 26, 2026
Merged

LucaCappelletti94 merged 1 commit into
mainfrom
share-div-infix-parsing

Conversation

@LucaCappelletti94

Copy link
Copy Markdown
Contributor

MySQL and Spark use the same keyword, operand parsing, and AST operator for DIV. One private helper keeps that grammar shared while each dialect retains its infix hook.

Addresses the DIV parsing duplication tracked in #2698.

Another echoes find.

@LucaCappelletti94 LucaCappelletti94 added MySQL Spark deduplication Removal of duplicated code labels Oct 25, 2026
@codecov-commenter

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 82.22%. Comparing base (72ce6a8) to head (266e9a8).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2718   +/-   ##
=======================================
  Coverage   82.22%   82.22%           
=======================================
  Files          42       42           
  Lines       35343    35339    -4     
  Branches    35343    35339    -4     
=======================================
- Hits        29060    29057    -3     
+ Misses       2716     2715    -1     
  Partials     3567     3567           

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@LucaCappelletti94

Copy link
Copy Markdown
Contributor Author

cc @alamb merging also this echo

@LucaCappelletti94
LucaCappelletti94 added this pull request to the merge queue Oct 26, 2026
Merged via the queue into main with commit 5106d69 Oct 26, 2026
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

deduplication Removal of duplicated code MySQL Spark

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants