-
Notifications
You must be signed in to change notification settings - Fork 767
Redshift: Support APPROXIMATE PERCENTILE_DISC #2480
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
BenSatori
wants to merge
5
commits into
apache:main
Choose a base branch
from
BenSatori:approximate-percentile-disc
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+42
−0
Open
Changes from all commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
88094e6
Adding support for APPROXIMATE PERCENTILE_DISC for Redshift
BenSatori 3698879
Fix no_std Redshift build
BenSatori ee307b6
Merge branch 'main' into approximate-percentile-disc
BenSatori 3bc9cc5
Merge branch 'main' into approximate-percentile-disc
BenSatori a7c7b5a
Merge branch 'main' into approximate-percentile-disc
BenSatori File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -557,3 +557,17 @@ fn parse_unpivot_expression() { | |
| fn test_interval_as_column_name() { | ||
| redshift().verified_stmt("SELECT * FROM table_name WHERE interval = 78"); | ||
| } | ||
|
|
||
| #[test] | ||
| fn parse_approximate_percentile_disc() { | ||
| redshift().one_statement_parses_to( | ||
| r#"SELECT TOP 10 date.caldate, | ||
| COUNT(totalprice), SUM(totalprice), | ||
| APPROXIMATE PERCENTILE_DISC(0.5) WITHIN GROUP (ORDER BY totalprice) | ||
| FROM listing | ||
| JOIN date ON listing.dateid = date.dateid | ||
| GROUP BY date.caldate | ||
| ORDER BY 3 DESC"#, | ||
| "SELECT TOP 10 date.caldate, COUNT(totalprice), SUM(totalprice), APPROXIMATE PERCENTILE_DISC(0.5) WITHIN GROUP (ORDER BY totalprice) FROM listing JOIN date ON listing.dateid = date.dateid GROUP BY date.caldate ORDER BY 3 DESC", | ||
|
Comment on lines
+564
to
+571
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. lets simplify this test input so that its clear what's being tested. also we should use verified_stmt |
||
| ); | ||
| } | ||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
hmm this doesnt look like the correct place for this functionality, we already have function parsers in the parser and support other percentile_disc variants. so that I think we likely just need to adjust that logic to accept redshifts' syntax