test: enable native path in lower/upper_enabled sql fixtures - #5619
Merged
comphead merged 1 commit intoSep 1, 2026
Merged
Conversation
Point the _enabled fixtures at spark.comet.caseConversion.enabled so they exercise the native case-conversion path instead of the no-op allowIncompatible setting. Fixes apache#5611 Co-authored-by: Cestercian <yashafaid@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #5611.
Rationale for this change
lower_enabled.sqlandupper_enabled.sqlwere meant to cover the native case-conversion path, but they set the no-op configspark.comet.expression.Lower/Upper.allowIncompatible. The native path is gated byspark.comet.caseConversion.enabled, so these fixtures currently exercise the same codegen dispatcher path as plainlower.sql/upper.sql.What changes are included in this PR?
_enabledfixtures atspark.comet.caseConversion.enabled=trueexpect_native(...)yet — that depends on open test: add helpers to assert whether an expression ran natively or via codegen dispatch #5610Are these changes tested?
Yes. After
make core(Spark 4.1):Both passed (1 test each, 0 failures).
Are there any user-facing changes?
No.