Skip to content

WIP Simplify Android colour structure - #2016

Draft
dpogue wants to merge 1 commit into
apache:masterfrom
dpogue:colors-xml
Draft

WIP Simplify Android colour structure#2016
dpogue wants to merge 1 commit into
apache:masterfrom
dpogue:colors-xml

Conversation

@dpogue

@dpogue dpogue commented Sep 9, 2026

Copy link
Copy Markdown
Member

Platforms affected

Android

Motivation and Context

To avoid run-time parsing of colours from config.xml, it would be best if the prepare step could set the colours properly in cdv_colors.xml as resources.

Description

Restructured the cdv_colors.xml file so that the default/system background is a separate variable that gets changed based on .

  • Set up cdv_background_color so it defaults to the system background
    • To be set from the BackgroundColor preference in config.xml
  • Added a cdv_status_bar_background color resource that defaults to transparent
    • To be set from the StatusBarBackgroundColor preference in config.xml
  • Retain cdv_splashscreen_background defaulting to the cdv_background_color
    • To be set from the SplashScreenBackgroundColor preference in config.xml

TODO

  • Actually setting the colour override values during prepare based on the preferences

Testing

Checklist

  • I've run the tests to see all new and existing tests pass
  • I added automated test coverage as appropriate for this change
  • Commit is prefixed with (platform) if this change only applies to one platform (e.g. (android))
  • If this Pull Request resolves an issue, I linked to the issue in the text above (and used the correct keyword to close issues using keywords)
  • I've updated the documentation if necessary

@dpogue dpogue changed the title Simplify Android colour structure WIP Simplify Android colour structure Sep 9, 2026
@codecov-commenter

codecov-commenter commented Sep 9, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 63.20%. Comparing base (a9a4511) to head (e309e6d).

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #2016   +/-   ##
=======================================
  Coverage   63.20%   63.20%           
=======================================
  Files          24       24           
  Lines        4922     4922           
=======================================
  Hits         3111     3111           
  Misses       1811     1811           

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants