Skip to content

fix: some static analysis warnings in Java code - #2015

Merged
dpogue merged 1 commit into
apache:masterfrom
dpogue:fixes
Sep 9, 2026
Merged

fix: some static analysis warnings in Java code#2015
dpogue merged 1 commit into
apache:masterfrom
dpogue:fixes

Conversation

@dpogue

@dpogue dpogue commented Sep 9, 2026

Copy link
Copy Markdown
Member

Platforms affected

Android

Motivation and Context

Static analysis identified a few warnings in our Java code. These were the easy ones to fix.

Description

  • Add @Override annotations where needed in a test
  • Fix improper if condition chaining in PluginManager
  • Fix inefficient empty string check in PluginManager
  • Don't use boxed Boolean type where simple boolean will do

Checklist

  • I've run the tests to see all new and existing tests pass

@codecov-commenter

codecov-commenter commented Sep 9, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 63.20%. Comparing base (a9a4511) to head (8b1b0a1).

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #2015   +/-   ##
=======================================
  Coverage   63.20%   63.20%           
=======================================
  Files          24       24           
  Lines        4922     4922           
=======================================
  Hits         3111     3111           
  Misses       1811     1811           

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@dpogue dpogue changed the title Fix some static analysis warnings in Java code fix: Fix some static analysis warnings in Java code Sep 9, 2026
@erisu erisu changed the title fix: Fix some static analysis warnings in Java code fix: some static analysis warnings in Java code Sep 9, 2026
@dpogue
dpogue merged commit 373fd9c into apache:master Sep 9, 2026
15 checks passed
@dpogue
dpogue deleted the fixes branch September 9, 2026 03:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants