Skip to content

ToStringStyle.appendDetail(StringBuffer,String,Collection|Map) bypass cycle registry.#1648

Merged
garydgregory merged 1 commit into
apache:masterfrom
garydgregory:bugfix/ToStringStyle_append_collection_cycle
May 17, 2026
Merged

ToStringStyle.appendDetail(StringBuffer,String,Collection|Map) bypass cycle registry.#1648
garydgregory merged 1 commit into
apache:masterfrom
garydgregory:bugfix/ToStringStyle_append_collection_cycle

Conversation

@garydgregory
Copy link
Copy Markdown
Member

The methods ToStringStyle.appendDetail(StringBuffer,String,Collection|Map) bypass the cycle registry.

Fixes Stack overflow on mutually-referential collections

  • Read the contribution guidelines for this project.
  • Read the ASF Generative Tooling Guidance if you use Artificial Intelligence (AI).
  • OP used AI to create the report and patch proposal. I added the Map variant.
  • Run a successful build using the default Maven goal with mvn; that's mvn on the command line by itself.
  • Write unit tests that match behavioral changes, where the tests fail if the changes to the runtime are not applied. This may not always be possible, but it is a best practice.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Each commit in the pull request should have a meaningful subject line and body. Note that a maintainer may squash commits during the merge process.

cycle registry.

Fixes Stack overflow on mutually-referential collections
@garydgregory garydgregory merged commit 552d7d0 into apache:master May 17, 2026
35 of 36 checks passed
@garydgregory garydgregory deleted the bugfix/ToStringStyle_append_collection_cycle branch May 17, 2026 14:10
garydgregory added a commit that referenced this pull request May 17, 2026
cycle registry (#1648).

Fixes Stack overflow on mutually-referential collections and maps
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant