Skip to content

COMPRESS-737: Check each folder's own CRC flag when sanity-checking SubStreamsInfo - #848

Open
Marti2203 wants to merge 1 commit into
apache:masterfrom
Marti2203:sevenz-substreams-folder-index
Open

Marti2203 wants to merge 1 commit into
apache:masterfrom
Marti2203:sevenz-substreams-folder-index

Conversation

@Marti2203

Copy link
Copy Markdown

Fixes COMPRESS-737.

sanityCheckSubStreamsInfo() advanced folderIdx inside a short-circuited condition, so after a folder with more than one substream it checked every later folder against the previous folder's CRC flag. The digest count came out wrong and a valid archive with folders [1 entry + folder CRC], [2 entries], [1 entry + folder CRC] was rejected with "Badly terminated SubStreamsInfo"; the same archive with the folders reordered opened. readSubStreamsInfo() already uses each folder's own flag. This advances the index once per folder.

The new resource COMPRESS-737.7z (141 bytes, COPY, four 3-byte entries) is such an archive; 7-Zip (7z t) reports it as OK. SevenZFileTest.testMixedFolderCrcs fails without the change and passes with it; SevenZFileTest and mvn -B -DskipTests -DskipITs pass.

This issue was found by an LLM-Enhanced Static Analysis Engine and verified manually. The patch and this description were prepared with AI assistance (Claude Code) and reviewed by me; the commit carries an Assisted-By: trailer.

…ubStreamsInfo

sanityCheckSubStreamsInfo() advanced its folder index only when the
earlier conditions did not short-circuit, so after a folder with more
than one substream it read the CRC flag of the previous folder and a
valid archive was rejected with "Badly terminated SubStreamsInfo".
Advance the index once per folder.

Assisted-By: Claude Code:claude-opus-5-5
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant