Repository navigation
Conversation
…ubStreamsInfo sanityCheckSubStreamsInfo() advanced its folder index only when the earlier conditions did not short-circuit, so after a folder with more than one substream it read the CRC flag of the previous folder and a valid archive was rejected with "Badly terminated SubStreamsInfo". Advance the index once per folder. Assisted-By: Claude Code:claude-opus-5-5
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes COMPRESS-737.
sanityCheckSubStreamsInfo()advancedfolderIdxinside a short-circuited condition, so after a folder with more than one substream it checked every later folder against the previous folder's CRC flag. The digest count came out wrong and a valid archive with folders [1 entry + folder CRC], [2 entries], [1 entry + folder CRC] was rejected with "Badly terminated SubStreamsInfo"; the same archive with the folders reordered opened.readSubStreamsInfo()already uses each folder's own flag. This advances the index once per folder.The new resource
COMPRESS-737.7z(141 bytes, COPY, four 3-byte entries) is such an archive; 7-Zip (7z t) reports it as OK.SevenZFileTest.testMixedFolderCrcsfails without the change and passes with it;SevenZFileTestandmvn -B -DskipTests -DskipITspass.This issue was found by an LLM-Enhanced Static Analysis Engine and verified manually. The patch and this description were prepared with AI assistance (Claude Code) and reviewed by me; the commit carries an
Assisted-By:trailer.