Repository navigation
Conversation
isPassFile() returned the result of the first directory rule, so a directory rule that does not match hid all later rules. Return true on a match and otherwise go on to the next rule. Assisted-By: Claude Code:claude-opus-5-5
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes COMPRESS-736.
PackingOptions.isPassFile(String)returned the result of the first directory rule (a pass entry not ending in.class) even when it did not match, so later exact or directory rules were never checked. This returns true on a match and otherwise continues with the next rule.PackingOptionsTest.testIsPassFileChecksAllRulesfails without the change and passes with it;PackingOptionsTestandmvn -B -DskipTests -DskipITspass.This issue was found by an LLM-Enhanced Static Analysis Engine and verified manually. The patch and this description were prepared with AI assistance (Claude Code) and reviewed by me; the commit carries an
Assisted-By:trailer.