Repository navigation
Conversation
…ffer SevenZOutputFile ignored the return value of SeekableByteChannel.write and counted every byte as written, so a channel that writes fewer bytes than requested produced a corrupt archive without an error. Loop until the buffer is written, as ZipIoUtil.writeAll does for ZIP. Assisted-By: Claude Code:claude-opus-5-5
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes COMPRESS-734.
SevenZOutputFileignored the return value ofSeekableByteChannel.write(ByteBuffer)at all five write sites, while still counting every byte in the CRC andfileBytesWritten. A channel that writes fewer bytes than are remaining, which theWritableByteChannelcontract allows, therefore produced a corrupt archive without any error. This adds awriteFullyloop, the same asZipIoUtil.writeAllfor ZIP, and uses it for every write.SevenZOutputFileTest.testPartialChannelWriteswrites through a channel that accepts at most 1 KiB per call and reads the archive back: without the change reading fails with "packSize (100,100) is out of range"; with it the content matches.SevenZOutputFileTest(36 tests) andmvn -B -DskipTests -DskipITspass.This issue was found by an LLM-Enhanced Static Analysis Engine and verified manually. The patch and this description were prepared with AI assistance (Claude Code) and reviewed by me; the commit carries an
Assisted-By:trailer.