Repository navigation
Conversation
…gth code ExplodingInputStream.fillBuffer() treated -1 from the length tree as a length, copying a byte from the empty dictionary when an imploded entry ends inside the length code of a back reference. Return as the literal and distance branches already do. Assisted-By: Claude Code:claude-opus-5-5
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes COMPRESS-733.
When an imploded (method 6) entry ends inside the length code of a back reference,
ExplodingInputStream.fillBuffer()used the -1 fromlengthTree.read(bits)as a length and copied one byte from the still empty dictionary. This returns there, as the literal and distance branches already do.ExplodingInputStreamTest.testTruncatedBackReferenceLengthdecodes such a stream; it gets 1 byte without the change and 0 with it.mvn -B -DskipTests -DskipITspasses.This issue was found by an LLM-Enhanced Static Analysis Engine and verified manually. The patch and this description were prepared with AI assistance (Claude Code) and reviewed by me; the commit carries an
Assisted-By:trailer.