do not mutate the input map in switch closure/transformer factories#700
Open
rootvector2 wants to merge 1 commit into
Open
do not mutate the input map in switch closure/transformer factories#700rootvector2 wants to merge 1 commit into
rootvector2 wants to merge 1 commit into
Conversation
Member
|
Hello @rootvector2 Please update the tests here and the new one from #696 to also make sure the result from calling the various Even though we might have other tests that do so, seeing a simple check in these new tests give me more confidence that there are no unintended side-effects. TY! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
switchClosure(Map),switchMapClosure(Map)andswitchMapTransformer(Map)pulled the default out withmap.remove(null)on the caller's map, so the null-key entry vanished from the caller's map as a side effect; spotted while extending the sibling fix in #696 that only touchedSwitchTransformer.switchTransformer, they now copy into aLinkedHashMapfirst.