Fix KVM import/unmanage support for SharedMountPoint pools

[prashanthr2]

Summary

• allow SharedMountPoint in KVM supported pool types for import/unmanage validation
• allow SharedMountPoint in KVM qemu-img supported pool types used by volume listing for import

Issue

Fixes #12954

Testing

• not run (targeted code-path change only)

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 17.60%. Comparing base (4708121) to head (8c641a3).

Additional details and impacted files

@@            Coverage Diff            @@
##               4.22   #12956   +/-   ##
=========================================
  Coverage     17.60%   17.60%           
+ Complexity    15677    15676    -1     
=========================================
  Files          5918     5918           
  Lines        531681   531681           
  Branches      65005    65005           
=========================================
  Hits          93623    93623           
  Misses       427498   427498           
  Partials      10560    10560           

Flag	Coverage Δ
uitests	3.70% <ø> (ø)
unittests	18.68% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

[DaanHoogland]

@blueorangutan package

[blueorangutan]

@DaanHoogland a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

[Copilot]

Pull request overview

Note

Copilot was unable to run its full agentic suite in this review.

This PR updates KVM volume import/unmanage and volume listing validation to recognize SharedMountPoint storage pools as supported, addressing missing support for that pool type (Fixes #12954).

Changes:

• Add StoragePoolType.SharedMountPoint to the KVM qemu-img supported pool types used for volume listing during import.
• Add StoragePoolType.SharedMountPoint to the KVM supported pool types used for import/unmanage validation.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.

File	Description
plugins/hypervisors/kvm/src/main/java/com/cloud/hypervisor/kvm/resource/wrapper/LibvirtGetVolumesOnStorageCommandWrapper.java	Extends the qemu-img supported pool type list to include SharedMountPoint.
api/src/main/java/org/apache/cloudstack/storage/volume/VolumeImportUnmanageService.java	Extends KVM import/unmanage validation to allow SharedMountPoint.

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[Copilot]

Arrays.asList(...) returns a fixed-size but still mutable list (elements can be replaced via set(...)). Since this is a shared static final constant, consider making it truly immutable (e.g., List.of(...) if available in your Java baseline, or wrap with Collections.unmodifiableList(...)) to prevent accidental runtime mutation.

[Copilot]

Same immutability concern here: Arrays.asList(...) produces a list that can still be mutated via set(...). Since this is an interface constant used for validation, it’s safer to expose an immutable list (e.g., List.of(...) or Collections.unmodifiableList(Arrays.asList(...))) to avoid unexpected behavior if any caller modifies it.

[weizhouapache]

code lgtm

not tested yet

[blueorangutan]

Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ el10 ✔️ debian ✔️ suse15. SL-JID 17397