CASSANDRA-21453 Move long running cluster metadata operations to a longer timeout#4899
Open
beobal wants to merge 3 commits into
Open
CASSANDRA-21453 Move long running cluster metadata operations to a longer timeout#4899beobal wants to merge 3 commits into
beobal wants to merge 3 commits into
Conversation
Replaces the fixed-retry commit loop with deadline-based exponential backoff for long running CMS commit operations (cms_commit_timeout=1h, 5s-60s jitter) to allow heavily contended CMS nodes time to commit transforms. Patch by Jon Meredith and Sam Tunnicliffe; reviewed by Jon Meredith and Sam Tunnicliffe for CASSANDRA-21453 Co-authored-by: Sam Tunnicliffe <samt@apache.org>
jonmeredith
approved these changes
Jun 29, 2026
jonmeredith
left a comment
jonmeredith
left a comment
Contributor
There was a problem hiding this comment.
👍 code looks good. I don't think any of the test failures are related to this change.
Comment on lines
+132
to
+144
| @Override | ||
| public String getCmsCommitMemberPreferencePolicy() | ||
| { | ||
| return DatabaseDescriptor.getCmsCommitMemberPreferencePolicy().name(); | ||
| } | ||
|
|
||
| @Override | ||
| public void setCmsCommitMemberPreferencePolicy(String policy) | ||
| { | ||
| DatabaseDescriptor.setCmsCommitMemberPreferencePolicy(policy); | ||
| logger.info("Set cms_commit_member_preference_policy to {}", policy); | ||
| } | ||
|
|
Contributor
There was a problem hiding this comment.
Good catch picking these up from CASSANDRA-21456 - thanks for including.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.