Skip to content

fix: propagate policy parse errors in string adapter LoadPolicy #1755

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
zjncs wants to merge 1 commit into
base: master
Choose a base branch
from
+16 −1
Open

fix: propagate policy parse errors in string adapter LoadPolicy #1755

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion persist/string-adapter/adapter.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,7 +49,9 @@ func (a *Adapter) LoadPolicy(model model.Model) error {
if str == "" {
continue
}
_ = persist.LoadPolicyLine(str, model)
if err := persist.LoadPolicyLine(str, model); err != nil {
return err
}
}

return nil
Expand Down
13 changes: 13 additions & 0 deletions persist/string-adapter/adapter_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -171,3 +171,16 @@ g, alice, data_group_admin
t.Error("unexpected enforce result")
}
}

// Test_LoadPolicyMalformedLine verifies that a malformed policy line (here an
// unterminated quoted field) makes LoadPolicy return an error instead of
// silently producing a model that lacks the rule.
func Test_LoadPolicyMalformedLine(t *testing.T) {
a := NewAdapter(`p, alice, data1, "read`)
m := model.NewModel()

err := a.LoadPolicy(m)
if err == nil {
t.Fatal("LoadPolicy() error = nil, want a parse error for the unterminated quoted field")
}
}
Loading