Skip to content

CAMEL-24829: WebsiteInstallerFixture - isolate PSModulePath for install.ps1 on Windows #26609

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
davsclaus merged 5 commits into from
Sep 19, 2026
Merged

CAMEL-24829: WebsiteInstallerFixture - isolate PSModulePath for install.ps1 on Windows #26609

Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
ba99c27
CAMEL-24829: windows-validator - temporary diagnostic for the ~24s in…
ammachado Sep 19, 2026
913b8b3
CAMEL-24829: windows-validator - bisect the environment behind the in…
ammachado Sep 19, 2026
de241bf
CAMEL-24829: WebsiteInstallerFixture - pass PSModulePath to install.p…
ammachado Sep 19, 2026
d5c338d
CAMEL-24829: WebsiteInstallerFixture - pin PSModulePath to Windows Po…
ammachado Sep 19, 2026
615cea2
CAMEL-24829: WebsiteInstallerFixture - point PSModulePath at the test…
ammachado Sep 19, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 10 additions & 7 deletions ...l-launcher/src/test/java/org/apache/camel/dsl/jbang/launcher/WebsiteInstallerFixture.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -64,8 +64,6 @@ final class WebsiteInstallerFixture implements AutoCloseable {
private static final String KEY_ALIAS = "camel-installer-test";
private static final String DEFAULT_BASE_VERSION = "9.9.9";
private static final Duration PROCESS_TIMEOUT = Duration.ofSeconds(60);
private static final Path POWERSHELL_MODULE_ANALYSIS_CACHE
= Path.of("target", "powershell", "ModuleAnalysisCache").toAbsolutePath();

record Result(int exit, String stdout, String stderr) {
}
Expand Down Expand Up @@ -457,13 +455,18 @@ Result run(List<String> command, Map<String, String> env) throws Exception {
pb.environment().put(name, value);
}
}
// PowerShell keeps its module analysis cache under LOCALAPPDATA, which every test points at a
// fresh home, so each powershell.exe launch would rebuild it from scratch when auto-loading
// Expand-Archive / Get-FileHash. Share one cache file across the whole test run instead.
Files.createDirectories(POWERSHELL_MODULE_ANALYSIS_CACHE.getParent());
pb.environment().put("PSModuleAnalysisCachePath", POWERSHELL_MODULE_ANALYSIS_CACHE.toString());
}
pb.environment().putAll(env);
String userProfile = env.get("USERPROFILE");
if (FakeJava.WINDOWS && userProfile != null) {
// Point PSModulePath at the isolated home's own (empty) user module directory. When PSModulePath
// is unset, or lists Windows PowerShell's built-in module directory, the first cmdlet call
// (install.ps1's Join-Path on line 29) spends ~18s on windows-latest, whose
// Program Files\WindowsPowerShell\Modules holds AWSPowerShell, Microsoft.Graph and SqlServer; that
// made every install.ps1 run in this suite cost ~20s. With only an unrelated directory listed, the
// same call takes 0.2s and Windows PowerShell still finds its built-in cmdlets.
pb.environment().put("PSModulePath", Path.of(userProfile, "Documents", "WindowsPowerShell", "Modules").toString());
}
String home = env.get("HOME");
if (home != null && Files.isDirectory(Path.of(home))) {
// Any accidental relative-path side effect lands in the isolated test HOME rather than
Expand Down
Loading