Revert "[Python] Propagate WriteToFiles finalization failures" - #40095
Merged
Abacn merged 1 commit intoSep 10, 2026
Conversation
This reverts commit f5ba5fa.
Contributor
|
Did this PR break something and I not see the test failure? |
Contributor
Author
|
There is a significant performance concern we should revisit. It's a common use case FileIO processing millions of files and a known bottleneck to listing metadata from gcs files (#20137). I remember each GET call takes ~100 ms. This adds hours of wall time when write to large number of files |
jrmccluskey
approved these changes
Sep 10, 2026
Contributor
|
Assigning reviewers: R: @tvalentyn for label python. This pull request likely touches a core component ("core" label). Please review with scrutiny. Note: If you would like to opt out of this review, comment Available commands:
The PR bot will only process comments in the main thread (not review comments). |
tvalentyn
approved these changes
Sep 10, 2026
Abacn
deleted the
revert-39993-bvolpato/python-fileio-finalization-errors
branch
September 10, 2026 18:05
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reverts #39993
reason: #39993 (comment)