Skip to content

Revert "[Python] Propagate WriteToFiles finalization failures" - #40095

Merged
Abacn merged 1 commit into
masterfrom
revert-39993-bvolpato/python-fileio-finalization-errors
Sep 10, 2026
Merged

Revert "[Python] Propagate WriteToFiles finalization failures"#40095
Abacn merged 1 commit into
masterfrom
revert-39993-bvolpato/python-fileio-finalization-errors

Conversation

@Abacn

@Abacn Abacn commented Sep 10, 2026

Copy link
Copy Markdown
Contributor

Reverts #39993

reason: #39993 (comment)

@jrmccluskey

Copy link
Copy Markdown
Contributor

Did this PR break something and I not see the test failure?

@Abacn

Abacn commented Sep 10, 2026

Copy link
Copy Markdown
Contributor Author

There is a significant performance concern we should revisit. It's a common use case FileIO processing millions of files and a known bottleneck to listing metadata from gcs files (#20137). I remember each GET call takes ~100 ms. This adds hours of wall time when write to large number of files

@github-actions

Copy link
Copy Markdown
Contributor

Assigning reviewers:

R: @tvalentyn for label python.

This pull request likely touches a core component ("core" label). Please review with scrutiny.

Note: If you would like to opt out of this review, comment assign to next reviewer.

Available commands:

  • stop reviewer notifications - opt out of the automated review tooling
  • remind me after tests pass - tag the comment author after tests pass
  • waiting on author - shift the attention set back to the author (any comment or push by the author will return the attention set to the reviewers)

The PR bot will only process comments in the main thread (not review comments).

@Abacn
Abacn merged commit 634bfe7 into master Sep 10, 2026
100 checks passed
@Abacn
Abacn deleted the revert-39993-bvolpato/python-fileio-finalization-errors branch September 10, 2026 18:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants