ARTEMIS-5958 refactor security store to expose hasPermission bool, to…#6309
Open
gtully wants to merge 1 commit intoapache:mainfrom
Open
ARTEMIS-5958 refactor security store to expose hasPermission bool, to…#6309gtully wants to merge 1 commit intoapache:mainfrom
gtully wants to merge 1 commit intoapache:mainfrom
Conversation
Contributor
|
There's a lack of tests here that cover the new split out hasPermissions API which would seems like something we'd want to add. I know the new API is called from the old check method now but it would seem like testing in isolation the new API would be prudent. |
… get a fast path for rbac chechs that restrict access. the regular check is still in play for invocations Assisted-by: Claude
Contributor
Author
|
good call, added some more test coverage for the new and existing api to protect it into the future. thanks @tabish121 for taking a look. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
… get a fast path for rbac chechs that restrict access. the regular check is still in play for invocations
Assisted-by: Claude