Repository navigation
GH-54645: [C++][FlightRPC][ODBC] Fix descriptor test query - #54695
Merged
kou merged 1 commit intoOct 21, 2026
Merged
Conversation
Dremio treats VALUE as a reserved keyword, which makes the remote descriptor lifecycle test fail during query execution. Use an alias accepted by both the SQLite mock and Dremio. Signed-off-by: Vikrant Puppala <vikrant.puppala@databricks.com>
|
|
github-actions
Bot
added
awaiting review
alinaliBQ
self-requested a review
October 20, 2026 16:38
alinaliBQ
reviewed
Oct 20, 2026
alinaliBQ
left a comment
alinaliBQ
left a comment
Collaborator
There was a problem hiding this comment.
The change LGTM, I added the CI: Extra: C++ label to invoke the ODBC tests
github-actions
Bot
added
awaiting committer review
4 of 5 tasks
Contributor
Author
|
@lidavidm could we merge this please? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rationale for this change
The Dremio-backed ODBC test suite fails in StatementTest/1.TestChangingAppRowDescriptorRebindsColumns because Dremio treats VALUE as a reserved keyword. The same query succeeds against the SQLite mock, so the failure was only exposed by the remote suite.
What changes are included in this PR?
Rename the test query alias from value to val, which is accepted by both SQLite and Dremio.
Are these changes tested?
Yes. Ran the Ubuntu 24.04 CI-equivalent ODBC job locally:
All 61 C++ test executables passed, including the Dremio-backed arrow-flight-sql-odbc-test.
Maintainer note: please apply the CI: Extra: C++ label so the ODBC CI job runs.
Are there any user-facing changes?
No. This is a test-only compatibility fix.
Was AI used for this PR?
In accordance to the AI generation guidelines, AI was used to investigate the failure, prepare the one-line test fix, run validation, and draft this description.
PR code and description written by:
Reviewed before submission by:
Closes #54645.