Repository navigation
GH-54646: [C++] Reject years out of range in the strptime timestamp parser - #54658
Conversation
|
Thanks for opening a pull request! This pull request has been automatically closed because you currently have 4 open pull requests, which is more than the limit of 3. Due to the increase in pull requests opened by AI bots, and in order to keep the review queue manageable, Apache Arrow limits contributors without repository access to at most 3 concurrently open pull requests. This helps make sure each pull request gets the attention it needs and that work in progress does not go stale. Once one of your other open pull requests has been merged or closed, you are welcome to reopen this one. See also: |
|
|
|
Re-opened. Could you rebase on main? |
…tamp parser The year was computed as tm_year + 1900, which can overflow int (e.g. with %s), and passed to date::year, which holds 16 bits, so out-of-range years gave wrong timestamps. Compute the year in 64 bits and reject it if date::year cannot hold it. Drafted by Claude Code (an AI agent) and reviewed & approved by pearu.
582cfd5 to
04354d7
Compare
dmitry-chirkov-dremio
left a comment
dmitry-chirkov-dremio
left a comment
There was a problem hiding this comment.
LGTM, no comments
github-actions
Bot
added
awaiting committer review
3 participants
Rationale for this change
The parser computed the year as
tm_year + 1900, which can overflowint(e.g. with%s), and passed it todate::year, which holds 16 bits, so a year out of range gave a wrong timestamp.What changes are included in this PR?
The year is computed in 64 bits and rejected if
date::yearcannot hold it.Are these changes tested?
Yes,
TimestampParser.StrptimeYearOutOfRangecovers a year that wraps around and one wheretm_year + 1900overflowsint. It needs%sand is skipped wherestrptimedoes not parse%sinto 64 bits (e.g. on Windows).Are there any user-facing changes?
Values whose year does not fit in 16 bits no longer parse with
strptimeformats.AI usage disclosure
Developed with AI assistance (Claude Code): the fix, the test and this description were AI-generated under my direction and reviewed line by line by me. I own and can debug these changes. No copyrighted material is included.