Repository navigation
Conversation
### Rationale for this change Closes apache#34389. GitHub can silently ignore an issue assignment when the contributor is not yet eligible to be assigned. The PR bot currently announces success even when the returned issue has no assignees. ### What changes are included in this PR? Send the assignees as an array and verify that the assignment response includes the PR creator before posting the success message. If assignment was ignored, link the issue and ask the contributor to leave a comment requesting assignment by a committer or collaborator, following the contributor documentation. Add dependency-free Node regression tests and run them in a read-only Dev workflow job. ### Are these changes tested? - `node --test .github/workflows/dev_pr/*.test.js` — 6 passed. Three cases fail with the original implementation. - Coverage includes successful assignment, silently ignored assignment, a different returned assignee, an already assigned issue, and unrelated PR titles. - JavaScript syntax checks, workflow YAML parsing, and `git diff --check` pass. ### Are there any user-facing changes? The bot reports assignment success only when GitHub confirms it. Contributors whose automatic assignment is rejected receive a link and instructions to request assignment instead of an incorrect success message.
limadog9
requested review from
assignUser,
jonkeane,
kou and
raulcd
as code owners
October 15, 2026 04:05
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rationale for this change
Closes #34389.
GitHub can silently ignore an issue assignment when the contributor is not yet eligible to be assigned. The PR bot currently announces success even when the returned issue has no assignees.
What changes are included in this PR?
Send the assignees as an array and verify that the assignment response includes the PR creator before posting the success message. If assignment was ignored, link the issue and ask the contributor to leave a comment requesting assignment by a committer or collaborator, following the contributor documentation.
Add dependency-free Node regression tests and run them in a read-only Dev workflow job.
Are these changes tested?
Are there any user-facing changes?
The bot reports assignment success only when GitHub confirms it. Contributors whose automatic assignment is rejected receive a link and instructions to request assignment instead of an incorrect success message.