Skip to content

GH-53519: [Python] Fix StringArray/LargeStringArray.from_buffers to accept int64 arguments #53728

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Asthenia0412 wants to merge 1 commit into from
Closed

GH-53519: [Python] Fix StringArray/LargeStringArray.from_buffers to accept int64 arguments #53728

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 6 additions & 6 deletions python/pyarrow/array.pxi
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4203,9 +4203,9 @@ cdef class StringArray(Array):
return cp.PyUnicode_DecodeUTF8(view.data(), <Py_ssize_t> view.size(), NULL)

@staticmethod
def from_buffers(int length, Buffer value_offsets, Buffer data,
Buffer null_bitmap=None, int null_count=-1,
int offset=0):
def from_buffers(int64_t length, Buffer value_offsets, Buffer data,
Buffer null_bitmap=None, int64_t null_count=-1,
int64_t offset=0):
"""
Construct a StringArray from value_offsets and data buffers.
If there are nulls in the data, also a null_bitmap and the matching
Expand Down Expand Up @@ -4241,9 +4241,9 @@ cdef class LargeStringArray(Array):
return cp.PyUnicode_DecodeUTF8(view.data(), <Py_ssize_t> view.size(), NULL)

@staticmethod
def from_buffers(int length, Buffer value_offsets, Buffer data,
Buffer null_bitmap=None, int null_count=-1,
int offset=0):
def from_buffers(int64_t length, Buffer value_offsets, Buffer data,
Buffer null_bitmap=None, int64_t null_count=-1,
int64_t offset=0):
"""
Construct a LargeStringArray from value_offsets and data buffers.
If there are nulls in the data, also a null_bitmap and the matching
Expand Down
Loading