Repository navigation
GH-53615: [C++][Parquet] Add ALP to file-level fuzz corpus - #53671
Conversation
|
|
There was a problem hiding this comment.
🟢 Approval recommended
The focused change correctly integrates ALP into existing FLOAT and DOUBLE corpus generation.
0 open findings
What changed in this PR
Adds ALP-encoded FLOAT and DOUBLE samples to the Parquet file-level fuzz corpus.
Changes:
- Adds
Encoding::ALPto supported floating-point corpus encodings. - Reuses existing datasets and null-probability variants.
| File | Description |
|---|---|
cpp/src/parquet/arrow/generate_fuzz_corpus.cc |
Enables ALP for generated floating-point columns. |
🧠 Review effort: Balanced
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
|
I didn't change the data samples since I don't have a good answer yet. AI has suggested me these cases for both
However, please correct me if I was wrong, these well-crafted cases will be altered in later fuzz runs at random so I don't think we need all the cases above. Do you have any suggestion? @pitrou |
Are these cases covered by Parquet data files in parquet-testing? Random mutation doesn't automatically produce all interesting cases, because of... randomness, so it's better to have a comprehensive seed corpus, but of course it's more tedious to develop and we might want to cut corners away. |
|
Yes, most of them are already covered by |
|
@github-actions crossbow submit fuzz |
|
@wgtmac Do you also attend to tackle the encoding-level Parquet fuzzer? |
|
Revision: 46f01a3 Submitted crossbow builds: ursacomputing/crossbow @ actions-57a3445bd3
|
The encoding-level corpus generator already includes ALP through arrow/cpp/src/parquet/decoder.cc Lines 2759 to 2762 in 46f01a3 |
Oh, well, you're right (and I wrote this code 🙃). |
|
Thanks @wgtmac ! |
Rationale for this change
Follow up on #48345 by including ALP in the generated Parquet file-level fuzz corpus.
What changes are included in this PR?
Add
Encoding::ALPtokFloatEncodings.Are these changes tested?
N/A.
Are there any user-facing changes?
No. This only changes fuzzing seed generation, not production reader or writer behavior.
Was AI used for this PR?
AI prepared and reviewed the one-line change and the PR description.
PR code and description written by:
Reviewed before submission by:
Closes #53615.