Skip to content

GH-41283: [Python] Raise instead of aborting on null map entries #53260

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
nil68657 wants to merge 1 commit into from
Closed

GH-41283: [Python] Raise instead of aborting on null map entries #53260

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions python/pyarrow/src/arrow/python/python_to_arrow.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -879,6 +879,8 @@ class PyListConverter : public ListConverter<T, PyConverter, PyConverterTrait> {
Status ValidateBuilder(const MapType*) {
if (this->list_builder_->key_builder()->null_count() > 0) {
return Status::Invalid("Invalid Map: key field cannot contain null values");
} else if (this->list_builder_->value_builder()->null_count() > 0) {
return Status::Invalid("Invalid Map: entries cannot be null");
} else {
return Status::OK();
}
Expand Down
9 changes: 9 additions & 0 deletions python/pyarrow/tests/test_convert_builtin.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2167,6 +2167,15 @@ def test_map_from_tuples():
pa.array([entry], type=pa.map_('i4', 'i4'))


def test_map_null_entry_raises():
# GH-41283: a null map entry must raise instead of aborting
ty = pa.map_(pa.string(), pa.int32())
with pytest.raises(pa.ArrowInvalid, match="entries cannot be null"):
pa.array([[{'key': 'a', 'value': 1}, None]], type=ty)
with pytest.raises(pa.ArrowInvalid, match="entries cannot be null"):
pa.array([[None]], type=pa.map_(pa.int32(), pa.int32()))


def test_dictionary_from_boolean():
typ = pa.dictionary(pa.int8(), value_type=pa.bool_())
a = pa.array([False, False, True, False, True], type=typ)
Expand Down
Loading