Repository navigation
Conversation
…pl::Validate() `std::vector::reserve(delta_)` only guarantees `capacity() >= delta_`, not `capacity() == delta_`. When the standard library/allocator uses size-returning allocations (such as C++23 `allocate_at_least`), `reserve(delta_)` can immediately set `capacity() > delta_`, causing `TDigestImpl::Validate()` to fail with "oversized tdigest buffer" even when the number of centroids is at most `delta_`. Check `size() > delta_` instead of `capacity() > delta_` to verify that the tdigest buffer did not expand past `delta_` elements.
dmitry-chirkov-dremio
approved these changes
Oct 7, 2026
dmitry-chirkov-dremio
approved these changes
Oct 12, 2026
Author
|
Hi Dmitry, can you please merge this PR? Do we need additional reviewers? Thanks, |
Contributor
See the guide here. |
Author
|
@pitrou Can you please take a look and/or suggest a different maintainer as a reviewer? Thanks, |
github-actions
Bot
added
awaiting committer review
Member
cyb70289
reviewed
Oct 14, 2026
ezbr
changed the title
Author
I filed issue #53777. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rationale for this change
std::vector::reserve(delta_)only guaranteescapacity() >= delta_, notcapacity() == delta_. When the C++ standard library and allocator use size-returning allocations (such as C++23allocate_at_least),reserve(delta_)can immediately setcapacity() > delta_, causingTDigestImpl::Validate()to fail with"oversized tdigest buffer"even when the number of centroids is at mostdelta_.Fixes issue #53777.
What changes are included in this PR?
Remove the check of
capacity() > delta_inTDigest::TDigestImpl::Validate().Are these changes tested?
Yes, covered by existing
TDigestTestunit tests incpp/src/arrow/util/tdigest_test.cc.Are there any user-facing changes?
No.
Was AI used for this PR?
PR code and description written by:
Reviewed before submission by: