Repository navigation
GH-51817: [Dev][Release] Add support for RC curl in download_rc_binaries.py - #51818
Merged
Merged
Conversation
|
|
Contributor
There was a problem hiding this comment.
Copilot review overview
🟢 Approval recommended
The regex correctly handles both stable and RC curl version formats without changing version comparisons.
Review effort: Balanced
Findings: None
What changed in this PR
Updates release tooling to recognize curl release-candidate version strings.
Changes:
- Accepts and ignores optional
-rcNsuffixes when parsing curl versions.
| File | Description |
|---|---|
dev/release/download_rc_binaries.py |
Extends curl version parsing for RC builds. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
raulcd
approved these changes
Oct 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rationale for this change
curl --versionuses the${MAJOR}.${MINOR}.${PATCH}-rc${RC}format for RC curl and Debian GNU/Linux sid uses RC curl.What changes are included in this PR?
Accept the
-rc${RC}part and ignore it.Are these changes tested?
Yes.
Are there any user-facing changes?
No.
Was AI used for this PR?
In accordance to the AI generation guidelines, please disclose below whether and how AI was used in this PR.
PR code and description written by:
Reviewed before submission by:
download_rc_binaries.pydoesn't accept RC curl #51817