Skip to content

GH-51751: [CI][Packaging] Fix formula path for homebrew-cpp job - #51756

Merged
kou merged 2 commits into
apache:mainfrom
tadeja:51751-homebrew-uriparser-dep
Oct 6, 2026
Merged

kou merged 2 commits into
apache:mainfrom
tadeja:51751-homebrew-uriparser-dep

Conversation

@tadeja

@tadeja tadeja commented Oct 5, 2026 •

Copy link
Copy Markdown
Member

Rationale for this change

Fix #51751
homebrew-core's formulae got letter-folders in 2023 but our macro from commit 5ad5ddc kept copying to top-level Formula/ hence homebrew-cpp job tested homebrew-core's formulae instead of both apache-arrow.rb and apache-arrow-glib.rb in dev/tasks/homebrew-formulae/

What changes are included in this PR?

Copy to Formula/a/ and
change to formula_opt_prefix("llvm") per audit check

Are these changes tested?

Yes.

Are there any user-facing changes?

No.

Was AI used for this PR?

PR code and description written by:

  • Human
  • AI

Reviewed before submission by:

  • Human
  • AI
  • Not reviewed

@github-actions github-actions Bot added the awaiting committer review Awaiting committer review label Oct 5, 2026
@tadeja tadeja changed the title [CI][Packaging] Nightly job homebrew-cpp fails to find uriparser Fix formula path [CI][Packaging] Fix formula path for homebrew-cpp job Oct 5, 2026
@github-actions

This comment was marked as resolved.

@tadeja tadeja changed the title [CI][Packaging] Fix formula path for homebrew-cpp job GH-51751: [CI][Packaging] Fix formula path for homebrew-cpp job Oct 5, 2026
@tadeja

tadeja commented Oct 5, 2026

Copy link
Copy Markdown
Member Author

@github-actions crossbow submit homebrew-cpp

@github-actions

github-actions Bot commented Oct 5, 2026

Copy link
Copy Markdown

⚠️ GitHub issue #51751 has been automatically assigned in GitHub to PR creator.

@github-actions

github-actions Bot commented Oct 5, 2026

Copy link
Copy Markdown

Revision: eac0f60

Submitted crossbow builds: ursacomputing/crossbow @ actions-9f8e923d8f

Task Status
homebrew-cpp GitHub Actions

@tadeja

tadeja commented Oct 5, 2026

Copy link
Copy Markdown
Member Author

With the path fix the job now tests our formula, so the new brew audit check finds this:
https://github.com/ursacomputing/crossbow/actions/runs/37315746512/job/111781924487#step:4:3644

Error: 1 problem in 1 formula detected.
  * line 74, col 21: Use `formula_opt_prefix("llvm")` instead of `Formula["llvm"].opt_prefix`.

This was already updated June in Homebrew/homebrew-core@208ed01

@tadeja

tadeja commented Oct 5, 2026

Copy link
Copy Markdown
Member Author

@github-actions crossbow submit homebrew-cpp

@github-actions

github-actions Bot commented Oct 5, 2026

Copy link
Copy Markdown

Revision: ba3ea28

Submitted crossbow builds: ursacomputing/crossbow @ actions-dda22448f3

Task Status
homebrew-cpp GitHub Actions

@tadeja
tadeja marked this pull request as ready for review October 5, 2026 21:11
Copilot AI balanced review requested due to automatic review settings October 5, 2026 21:11

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot review overview

🟢 Approval recommended

The focused changes correctly address the reported CI failure and Homebrew audit requirement.

Review effort: Balanced
Findings: None

What changed in this PR

Fixes the Homebrew CI job to test Arrow’s local formulae rather than homebrew-core versions.

Changes:

  • Copies Arrow formulae into Homebrew’s letter-based Formula/a/ directory.
  • Uses the audit-compliant LLVM prefix helper.
File Description
dev/​tasks/​macros.jinja Corrects the Homebrew formula destination.
dev/​tasks/​homebrew-formulae/​apache-arrow.rb Updates LLVM prefix resolution.

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

@kou kou left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@kou
kou merged commit 0e9fca3 into apache:main Oct 6, 2026
33 of 34 checks passed
@kou kou removed the awaiting committer review Awaiting committer review label Oct 6, 2026
@github-actions github-actions Bot added the awaiting merge Awaiting merge label Oct 6, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

awaiting merge Awaiting merge

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[CI][Packaging] Nightly job homebrew-cpp fails to find uriparser

3 participants