GH-51751: [CI][Packaging] Fix formula path for homebrew-cpp job - #51756
Conversation
This comment was marked as resolved.
This comment was marked as resolved.
|
@github-actions crossbow submit homebrew-cpp |
|
|
|
Revision: eac0f60 Submitted crossbow builds: ursacomputing/crossbow @ actions-9f8e923d8f
|
|
With the path fix the job now tests our formula, so the new brew audit check finds this: Error: 1 problem in 1 formula detected.
* line 74, col 21: Use `formula_opt_prefix("llvm")` instead of `Formula["llvm"].opt_prefix`.This was already updated June in Homebrew/homebrew-core@208ed01 |
|
@github-actions crossbow submit homebrew-cpp |
|
Revision: ba3ea28 Submitted crossbow builds: ursacomputing/crossbow @ actions-dda22448f3
|
There was a problem hiding this comment.
Copilot review overview
🟢 Approval recommended
The focused changes correctly address the reported CI failure and Homebrew audit requirement.
Review effort: Balanced
Findings: None
What changed in this PR
Fixes the Homebrew CI job to test Arrow’s local formulae rather than homebrew-core versions.
Changes:
- Copies Arrow formulae into Homebrew’s letter-based
Formula/a/directory. - Uses the audit-compliant LLVM prefix helper.
| File | Description |
|---|---|
dev/tasks/macros.jinja |
Corrects the Homebrew formula destination. |
dev/tasks/homebrew-formulae/apache-arrow.rb |
Updates LLVM prefix resolution. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Rationale for this change
Fix #51751
homebrew-core's formulae got letter-folders in 2023 but our macro from commit 5ad5ddc kept copying to top-level
Formula/hence homebrew-cpp job tested homebrew-core's formulae instead of both apache-arrow.rb and apache-arrow-glib.rb indev/tasks/homebrew-formulae/What changes are included in this PR?
Copy to
Formula/a/andchange to
formula_opt_prefix("llvm")per audit checkAre these changes tested?
Yes.
Are there any user-facing changes?
No.
Was AI used for this PR?
PR code and description written by:
Reviewed before submission by: